new lint: missing-spin-loop
#8174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
llogiq
force-pushed
the
missing-spin-loop
branch
2 times, most recently
from
0394b51
to
d1e704e
Compare
flip1995
added
S-waiting-on-author
llogiq
force-pushed
the
missing-spin-loop
branch
from
d1e704e
to
2b03d5e
Compare
|
This is blocked on rust/#92870. |
llogiq
added
the
S-blocked
flip1995
removed
the
S-blocked
llogiq
force-pushed
the
missing-spin-loop
branch
from
2b03d5e
to
b6379bf
Compare
|
No longer blocked. No idea why the base test was cancelled, but everything seems to be in order here locally. r? @flip1995 |
flip1995
approved these changes
Mar 2, 2022
| if let ExprKind::MethodCall(method, [callee, ..], _) = unpack_cond(cond).kind; | ||
| if [sym::load, sym::compare_exchange, sym::compare_exchange_weak].contains(&method.ident.name); | ||
| if let ty::Adt(def, _substs) = cx.typeck_results().expr_ty(callee).kind(); | ||
| //FIXME: The AtomicBool sym is apparently not correctly assigned, once it is, uncomment: |
There was a problem hiding this comment.
I think this fixme can now be removed.
llogiq
force-pushed
the
missing-spin-loop
branch
from
b6379bf
to
9f1080c
Compare
|
📌 Commit 9f1080c has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7809. I went with the shorter name because the function is called
std::hint::spin_loop. It doesn't yet detectwhile letloops. I left that for a follow-up PR.changelog: new lint: [
missing_spin_loop]