-
Notifications
You must be signed in to change notification settings - Fork 12.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #94329 - flip1995:clippyup, r=Manishearth
Update Clippy r? `@Manishearth`
- Loading branch information
Showing
114 changed files
with
3,465 additions
and
1,444 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
src/tools/clippy/clippy_lints/src/cargo/common_metadata.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| //! lint on missing cargo common metadata | ||
|
|
||
| use cargo_metadata::Metadata; | ||
| use clippy_utils::diagnostics::span_lint; | ||
| use rustc_lint::LateContext; | ||
| use rustc_span::source_map::DUMMY_SP; | ||
|
|
||
| use super::CARGO_COMMON_METADATA; | ||
|
|
||
| pub(super) fn check(cx: &LateContext<'_>, metadata: &Metadata, ignore_publish: bool) { | ||
| for package in &metadata.packages { | ||
| // only run the lint if publish is `None` (`publish = true` or skipped entirely) | ||
| // or if the vector isn't empty (`publish = ["something"]`) | ||
| if package.publish.as_ref().filter(|publish| publish.is_empty()).is_none() || ignore_publish { | ||
| if is_empty_str(&package.description) { | ||
| missing_warning(cx, package, "package.description"); | ||
| } | ||
|
|
||
| if is_empty_str(&package.license) && is_empty_str(&package.license_file) { | ||
| missing_warning(cx, package, "either package.license or package.license_file"); | ||
| } | ||
|
|
||
| if is_empty_str(&package.repository) { | ||
| missing_warning(cx, package, "package.repository"); | ||
| } | ||
|
|
||
| if is_empty_str(&package.readme) { | ||
| missing_warning(cx, package, "package.readme"); | ||
| } | ||
|
|
||
| if is_empty_vec(&package.keywords) { | ||
| missing_warning(cx, package, "package.keywords"); | ||
| } | ||
|
|
||
| if is_empty_vec(&package.categories) { | ||
| missing_warning(cx, package, "package.categories"); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fn missing_warning(cx: &LateContext<'_>, package: &cargo_metadata::Package, field: &str) { | ||
| let message = format!("package `{}` is missing `{}` metadata", package.name, field); | ||
| span_lint(cx, CARGO_COMMON_METADATA, DUMMY_SP, &message); | ||
| } | ||
|
|
||
| fn is_empty_str<T: AsRef<std::ffi::OsStr>>(value: &Option<T>) -> bool { | ||
| value.as_ref().map_or(true, |s| s.as_ref().is_empty()) | ||
| } | ||
|
|
||
| fn is_empty_vec(value: &[String]) -> bool { | ||
| // This works because empty iterators return true | ||
| value.iter().all(String::is_empty) | ||
| } |
Oops, something went wrong.