Skip to content

Commit

Permalink
Rollup merge of #113145 - joshtriplett:style-guide-document-assignmen…
Browse files Browse the repository at this point in the history
…t-newlines, r=joshtriplett

style-guide: Document newline rules for assignment operators

The style guide gives general rules for binary operators including
assignment, and one of those rules says to put the operator on the
subsequent line; the style guide needs to explicitly state the exception
of breaking *after* assignment operators rather than before.

This is already what rustfmt does and what users do; this fixes the
style guide to match the expected default style.
  • Loading branch information
fee1-dead committed Jul 6, 2023
2 parents e461502 + 03e64f4 commit baba904
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/doc/style-guide/src/expressions.md
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,9 @@ Use parentheses liberally, do not necessarily elide them due to precedence.
Tools should not automatically insert or remove parentheses. Do not use spaces
to indicate precedence.

If line-breaking, put the operator on a new line and block indent. Put each
sub-expression on its own line. E.g.,
If line-breaking, block-indent each subsequent line. For assignment operators,
break after the operator; for all other operators, put the operator on the
subsequent line. Put each sub-expression on its own line:

```rust
foo_bar
Expand Down

0 comments on commit baba904

Please sign in to comment.