Omit commented-out options in configure.py
#108612
Labels
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
E-medium
Call for participation: Medium difficulty. Experience needed to fix: Intermediate.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Right now,
./configure --set rust.incremental
generates an 809 line file, making it very hard to tell what's actually modified.configure-args
kind of helps with this, but doesn't show up until line 331, so it's not obvious to people who aren't experienced with bootstrap. We should change configure.py to only include options that are actually set, so it's easier to tell how it differs from the defaults. This also avoids issues where the comments inconfig.toml
drift away from the comments inconfig.toml.example
over time.Unfortunately config.toml.example is just a bunch of comments so it's annoying to actually do this and keep the relevant comments in
config.toml
... maybe we can search back upwards to the nearest blank line?Relevant code:
rust/src/bootstrap/configure.py
Lines 383 to 393 in 6379c72
The text was updated successfully, but these errors were encountered: