Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy always being rebuild with --bless #122834

Closed
matthiaskrgr opened this issue Mar 21, 2024 · 1 comment · Fixed by #122838
Closed

tidy always being rebuild with --bless #122834

matthiaskrgr opened this issue Mar 21, 2024 · 1 comment · Fixed by #122838
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Mar 21, 2024 •
edited
Loading

this works fine:

x.py test
x.py test

x.py test
x.py test --bless

this also works

x.py test --bless
x.py test --bless

this seems to rebuild tidy for the second invocation? as if --bless somehow modified tidy itself which then need to be rebuilt?
@matthiaskrgr matthiaskrgr added the C-bug Category: This is a bug. label Mar 21, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 21, 2024
@matthiaskrgr matthiaskrgr added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Mar 21, 2024
@matthiaskrgr matthiaskrgr changed the title tidy always being rebuild tidy always being rebuild with --bless Mar 21, 2024
@workingjubilee
Copy link
Member

workingjubilee commented Mar 21, 2024 •
edited
Loading

It's probably due to rewriting issues.txt with the same data. I hadn't considered the vagaries of incremental.

@workingjubilee workingjubilee mentioned this issue Mar 21, 2024
Merged
jhpratt added a commit to jhpratt/rust that referenced this issue Mar 21, 2024
@jhpratt
Rollup merge of rust-lang#122838 - workingjubilee:less-catholic-bless…
12c0915 
…ings-to-prevent-incremental-protests, r=matthiaskrgr

Avoid noop rewrite of issues.txt

Fixes rust-lang#122834

r? `@matthiaskrgr`
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 21, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 21, 2024
@matthiaskrgr
Rollup merge of rust-lang#122838 - workingjubilee:less-catholic-bless…
70c095e 
…ings-to-prevent-incremental-protests, r=matthiaskrgr

Avoid noop rewrite of issues.txt

Fixes rust-lang#122834

r? ``@matthiaskrgr``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#122838 - workingjubilee:less-catholic-bless…
d9e90ef 
…ings-to-prevent-incremental-protests, r=matthiaskrgr

Avoid noop rewrite of issues.txt

Fixes rust-lang#122834

r? ```@matthiaskrgr```
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 22, 2024
@rust-timer
Unrolled build for rust-lang#122838
7236ccf 
Rollup merge of rust-lang#122838 - workingjubilee:less-catholic-blessings-to-prevent-incremental-protests, r=matthiaskrgr

Avoid noop rewrite of issues.txt

Fixes rust-lang#122834

r? ```@matthiaskrgr```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid noop rewrite of issues.txt workingjubilee/rustc
4 participants
@matthiaskrgr @jieyouxu @workingjubilee @rustbot