Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete all code for handling lldb and gdb versions that don't support Rust natively #128953

Closed
4 tasks done
saethlin opened this issue Aug 11, 2024 · 1 comment · Fixed by #129218
Closed
4 tasks done

Delete all code for handling lldb and gdb versions that don't support Rust natively #128953

saethlin opened this issue Aug 11, 2024 · 1 comment · Fixed by #129218
Assignees
@saethlin
Labels
A-compiletest Area: the compiletest test runner A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-debugging Working group: Bad Rust debugging experiences

Comments

@saethlin
Copy link
Member

saethlin commented Aug 11, 2024 •
edited
Loading

We have a fair bit of code in both src/tools/compiletest and tests/debuginfo devoted to handling the 7.X releases of gdb, because those had no built-in Rust support. But as of this year at least, the oldest supported RHEL version is now shipping gdb 8.2 so there's no reason for us to be pretending to support versions of gdb before 8.2.

The dev guide also vaguely indicates that this distinction for lldb shouldn't exist anymore:

https://github.com/rust-lang/rustc-dev-guide/blob/43d83780db545a1ed6d45773312fc578987e3968/src/tests/compiletest.md?plain=1#L216
https://github.com/rust-lang/rustc-dev-guide/blob/43d83780db545a1ed6d45773312fc578987e3968/src/tests/compiletest.md?plain=1#L253-L255

  • Delete all the gdbg annotations in tests/debuginfo, and convert all gdbr to just gdb
  • Delete all the lldbg annotations in tests/debuginfo and convert all lldbr to lldb
  • Check if the tests still pass (you've got a 50/50 shot on this, debuginfo tests are cursed)
  • Delete the code in compiletest that handles this "Rust support" version gap for gdb, and for lldb
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 11, 2024
@saethlin saethlin added E-help-wanted Call for participation: Help is requested to fix this issue. A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) labels Aug 11, 2024
@jieyouxu jieyouxu added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-compiletest Area: the compiletest test runner T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 11, 2024
@saethlin saethlin added the WG-debugging Working group: Bad Rust debugging experiences label Aug 11, 2024
@saethlin saethlin self-assigned this Aug 17, 2024
@saethlin saethlin mentioned this issue Aug 17, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 18, 2024
@bors
Auto merge of rust-lang#129218 - saethlin:gdb-supports-rust-now, r=<try>
03db455 
Delete debuginfo test suite support for gdb/lldb without native Rust support

Implements rust-lang#128953

I also deleted all the `min-lldb-version: 310` comments, because the oldest compatible distro I can find is Ubuntu 16.04 which ships lldb 3.8, though of course the package that the Ubuntu maintainers put together for that is broken.

r? `@ghost`

try-job: aarch64-apple
try-job: aarch64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: i686-gnu
try-job: i686-gnu-nopt
try-job: i686-mingw
try-job: i686-msvc
try-job: test-various
try-job: x86_64-apple-1
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 18, 2024
@bors
Auto merge of rust-lang#129218 - saethlin:gdb-supports-rust-now, r=<try>
1635624 
Delete debuginfo test suite support for gdb/lldb without native Rust support

Implements rust-lang#128953

I also deleted all the `min-lldb-version: 310` comments, because the oldest compatible distro I can find is Ubuntu 16.04 which ships lldb 3.8, though of course the package that the Ubuntu maintainers put together for that is broken.

Rocky Linux 8 amusingly ships lldb 17, even though it has a similar glibc and kernel version.

This PR is multiple highly mechanical changes. Some of the commits were created by just running `sed`. You may find it easier to review each commit separately.

try-job: x86_64-apple-1
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 18, 2024
@bors
Auto merge of rust-lang#129218 - saethlin:gdb-supports-rust-now, r=<try>
03087b4 
Delete debuginfo test suite support for gdb/lldb without native Rust support

Implements rust-lang#128953

I also deleted all the `min-lldb-version: 310` comments, because the oldest compatible distro I can find is Ubuntu 16.04 which ships lldb 3.8, though of course the package that the Ubuntu maintainers put together for that is broken.

Rocky Linux 8 amusingly ships lldb 17, even though it has a similar glibc and kernel version.

This PR is multiple highly mechanical changes. Some of the commits were created by just running `sed`. You may find it easier to review each commit separately.

try-job: x86_64-apple-1
try-job: aarch64-apple
@saethlin saethlin linked a pull request Aug 18, 2024 that will close this issue
Delete debuginfo test suite infra for gdb without Rust support and lldb with Rust support #129218
Merged
@saethlin
Copy link
Member Author

Turns out the modern side of the version split for lldb is the version without Rust support. That's a bummer, but still the goal here is to delete unused code.

@saethlin saethlin removed the E-help-wanted Call for participation: Help is requested to fix this issue. label Aug 18, 2024
bors added a commit to rust-lang-ci/rust that referenced this issue Aug 19, 2024
@bors
Auto merge of rust-lang#129218 - saethlin:gdb-supports-rust-now, r=ji…
4fe1e2b 
…eyouxu

Delete debuginfo test suite infra for gdb without Rust support and lldb with Rust support

Implements rust-lang#128953

I also deleted all the `min-lldb-version: 310` comments, because the oldest compatible distro I can find is Ubuntu 16.04 which ships lldb 3.8, though of course the package that the Ubuntu maintainers put together for that is broken.

Rocky Linux 8 amusingly ships lldb 17, even though it has a similar glibc and kernel version.

This PR is multiple highly mechanical changes. Some of the commits were created by just running `sed`. You may find it easier to review each commit separately.
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Aug 20, 2024
@bors
Auto merge of #129218 - saethlin:gdb-supports-rust-now, r=jieyouxu
d6a5e83 
Delete debuginfo test suite infra for gdb without Rust support and lldb with Rust support

Implements rust-lang/rust#128953

I also deleted all the `min-lldb-version: 310` comments, because the oldest compatible distro I can find is Ubuntu 16.04 which ships lldb 3.8, though of course the package that the Ubuntu maintainers put together for that is broken.

Rocky Linux 8 amusingly ships lldb 17, even though it has a similar glibc and kernel version.

This PR is multiple highly mechanical changes. Some of the commits were created by just running `sed`. You may find it easier to review each commit separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saethlin saethlin

Labels
A-compiletest Area: the compiletest test runner A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-debugging Working group: Bad Rust debugging experiences
Projects
compiletest maintenance and improvements
Status: Done
Milestone
No milestone
3 participants
@saethlin @jieyouxu @rustbot