rustdoc should support --target for doc tests #16357
Comments
|
cc @SimonSapin |
|
I also can't pass --extern so I can't run doc tests on anything that uses the new liburl. |
|
I believe |
|
Hmm. I'll give that a shot. |
|
@huonw That worked. So Servo is down to just needing --target. |
|
Note that rustdoc does indeed support I've updated the title to reflect that this just needs |
alexcrichton
changed the title
alexcrichton
changed the title
|
The test runner doesn't need it, only the compiler. If this works now, I should be able to modify the makefile to use it, but the --help doesn't mention --target at all. |
|
You may have an older version of rustdoc, the |
|
Closing as rustdoc does support |
Commit 6a06f6f (Deduplicate reference search results, 2022-11-07) deduplicates references within each definition. There is an edge case when requesting references of a macro argument. Apparently, our descend_into_macros() stanza in references.rs produces a cartesian product of - references inside the macro times - times references outside the macro. Since the above deduplication only applies to the references within a single definition, we return them all, leading to many redundant references. Work around this by deduplicating definitions as well. Perhaps there is a better fix to not produce this cartesian product in the first place; but I think at least for definitions the problem would remain; a macro can contain multiple definitions of the same name, but since the navigation target will be the unresolved location, it's the same for all of them. We can't use unique() because we don't want to drop references that don't have a declaration (though I dont' have an example for this case). I discovered this working with the "bitflags" macro from the crate of the same name. Fixes rust-lang#16357
…h-macros, r=Veykril Deduplicate references when some of them are in macro expansions EDIT: I wonder if this is a regression, I'll try to investigate. Commit 6a06f6f (Deduplicate reference search results, 2022-11-07) deduplicates references within each definition. Apparently our descend_into_macros() stanza returns one definition for each time a name is used in a macro. Each of those definitions has the same set of references. We return them all, leading to many redundant references. Work around this by deduplicating definitions as well. Perhaps there is a better fix to not produce duplicate definitions in the first place. I discovered this working with the "bitflags" macro from the crate of the same name. Fixes rust-lang#16357
Currently there is no way to pass arbitrary compiler flags to rustdoc. This means that I can't use rustdoc to check cross compiled libraries. For example, checking
i686-unknown-linux-gnufromx86_64-unknown-linux-gnuis impossible because I can't pass--targetto rustdoc.I've worked around this issue for now by disabling doctests in Servo, but that is not ideal.
The text was updated successfully, but these errors were encountered: