Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CSS reset to the docs #17929

Closed
mahkoh opened this issue Oct 10, 2014 · 6 comments · Fixed by #22740
Closed

Add a CSS reset to the docs #17929

mahkoh opened this issue Oct 10, 2014 · 6 comments · Fixed by #22740
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@mahkoh
Copy link
Contributor

mahkoh commented Oct 10, 2014

Both the text and the background are black in the steam ingame browser.

@thestinger
Copy link
Contributor

The Steam in-game browser is still on Chromium 35 (known security bugs and all) so I think this is more a problem on their end.

@tomjakubowski
Copy link
Contributor

We probably just need to set background-color to a light color ourselves. It wouldn't surprise me if Steam has a user agent style that sets the default background color to dark to match the rest of their UI.

@nodakai
Copy link
Contributor

nodakai commented Oct 11, 2014

Web frontent engineers would use "CSS Reset" scripts:

@kmcallister kmcallister added A-amusing E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Feb 13, 2015
@kmcallister kmcallister changed the title Docs and reference don't work in the steam ingame browser. Add a CSS reset to the docs Feb 13, 2015
@steveklabnik
Copy link
Member

@tomjakubowski
Copy link
Contributor

It doesn't really matter that we're using a CSS reset because CSS resets won't do what was originally asked in this issue.

If you set body/headline text color, then you have to set the background color too; otherwise you get conflicts with user and user agent stylesheets, like with Steam's browser. CSS resets don't usually set background or text colors on main elements, and they shouldn't.

@frewsxcv
Copy link
Member

A screenshot of what this issue is:

screen shot 2015-02-23 at 6 01 03 pm

frewsxcv added a commit to frewsxcv/rust that referenced this issue Feb 23, 2015
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 24, 2015
lnicola pushed a commit to lnicola/rust that referenced this issue Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants