Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macros: The line number that panic! reports can be wrong in macro invocations #40649

Closed
jseyfried opened this issue Mar 19, 2017 · 1 comment · Fixed by #40597
Closed

macros: The line number that panic! reports can be wrong in macro invocations #40649

jseyfried opened this issue Mar 19, 2017 · 1 comment · Fixed by #40597
Assignees
@jseyfried

Comments

@jseyfried
Copy link
Contributor

For example,

macro_rules! identity_macro { ($($t:tt)*) => { $($t)* } }

fn main() {
    identity_macro! { //< Today, the message says we panic here.
        panic!("")
    }
}
@jseyfried jseyfried mentioned this issue Mar 19, 2017
Merged
@jseyfried
Copy link
Contributor Author

Fixed in #40597.

@jseyfried jseyfried self-assigned this Mar 25, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 26, 2017
@frewsxcv
Rollup merge of rust-lang#40597 - jseyfried:improve_span_expn_info, r…
e351a87 
…=nrc

macros: improve `Span`'s expansion information

This PR improves `Span`'s expansion information. More specifically:
 - It refactors AST node span construction to preserve expansion information.
   - Today, we only use the underlying tokens' `BytePos`s, throwing away the `ExpnId`s.
   - This improves the accuracy of AST nodes' expansion information, fixing rust-lang#30506.
 - It refactors `span.expn_id: ExpnId` to `span.ctxt: SyntaxContext` and removes `ExpnId`.
   - This gives all tokens as much hygiene information as `Ident`s.
   - This is groundwork for procedural macros 2.0 `TokenStream` API.
   - This is also groundwork for declarative macros 2.0, which will need this hygiene information for some non-`Ident` tokens.
 - It simplifies processing of spans' expansion information throughout the compiler.
 - It fixes rust-lang#40649.

r? @nrc
bors added a commit that referenced this issue Mar 28, 2017
@bors
Auto merge of #40597 - jseyfried:improve_span_expn_info, r=<try>
b329a7a 
macros: improve `Span`'s expansion information

This PR improves `Span`'s expansion information. More specifically:
 - It refactors AST node span construction to preserve expansion information.
   - Today, we only use the underlying tokens' `BytePos`s, throwing away the `ExpnId`s.
   - This improves the accuracy of AST nodes' expansion information, fixing #30506.
 - It refactors `span.expn_id: ExpnId` to `span.ctxt: SyntaxContext` and removes `ExpnId`.
   - This gives all tokens as much hygiene information as `Ident`s.
   - This is groundwork for procedural macros 2.0 `TokenStream` API.
   - This is also groundwork for declarative macros 2.0, which will need this hygiene information for some non-`Ident` tokens.
 - It simplifies processing of spans' expansion information throughout the compiler.
 - It fixes #40649.

r? @nrc
bors added a commit that referenced this issue Mar 30, 2017
@bors
Auto merge of #40597 - jseyfried:improve_span_expn_info, r=jseyfried
fe15119 
macros: improve `Span`'s expansion information

This PR improves `Span`'s expansion information. More specifically:
 - It refactors AST node span construction to preserve expansion information.
   - Today, we only use the underlying tokens' `BytePos`s, throwing away the `ExpnId`s.
   - This improves the accuracy of AST nodes' expansion information, fixing #30506.
 - It refactors `span.expn_id: ExpnId` to `span.ctxt: SyntaxContext` and removes `ExpnId`.
   - This gives all tokens as much hygiene information as `Ident`s.
   - This is groundwork for procedural macros 2.0 `TokenStream` API.
   - This is also groundwork for declarative macros 2.0, which will need this hygiene information for some non-`Ident` tokens.
 - It simplifies processing of spans' expansion information throughout the compiler.
 - It fixes #40649.
 - It fixes #39450 and fixes part of #23480.

r? @nrc
@jseyfried jseyfried mentioned this issue May 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jseyfried jseyfried

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

macros: improve Span's expansion information jseyfried/rust
1 participant
@jseyfried