Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-disable rls packaging for 1.19 #42357

Closed
brson opened this issue Jun 1, 2017 · 3 comments
Closed

Re-disable rls packaging for 1.19 #42357

brson opened this issue Jun 1, 2017 · 3 comments
Assignees
@brson
Labels
P-high High priority
Milestone
1.19

Comments

@brson
Copy link
Contributor

brson commented Jun 1, 2017

Currently on the 1.19 branch rls is packaged for standalone installers and also (I think) for rustup.

Unfortunately there is still debate about the the story we want to tell here wrt the stability of the RLS, so it's not happening for 1.19

Revert the PR that added it to the installers and make sure it's not packaged for rustup. Since 1.19 branches soon this will likely need to be backported.

cc @alexcrichton @nrc
@brson brson added the P-high High priority label Jun 1, 2017
@brson brson added this to the 1.19 milestone Jun 1, 2017
@brson brson mentioned this issue Jun 1, 2017
Closed
@alexcrichton alexcrichton mentioned this issue Jun 6, 2017
Merged
bors added a commit that referenced this issue Jun 6, 2017
@bors
Auto merge of #42472 - alexcrichton:beta-next, r=alexcrichton
a879841 
[beta] Prepare the 1.19.0 beta release

* ~~Update the cargo submodule~~
* Update the stage0 bootstrap to 1.18.0 release
* Update release channel to beta
* Disable the RLS (this'll happen next beta hopefully)

Closes #42357
@brson brson mentioned this issue Jul 8, 2017
Closed
@brson brson self-assigned this Jul 8, 2017
@brson
Copy link
Contributor Author

brson commented Jul 8, 2017

It looks like this was disabled in this backport.

@brson
Copy link
Contributor Author

brson commented Jul 8, 2017

AFAIK there is no movement to get rls stable for 1.20 so we may have to do it again....

@brson brson mentioned this issue Jul 13, 2017
Closed
@brson
Copy link
Contributor Author

brson commented Jul 13, 2017

I'm going to claim this is done.

@brson brson closed this as completed Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
P-high High priority
Projects
None yet
Milestone
1.19
Development

No branches or pull requests
1 participant
@brson