Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for RFC 2296, Option::replace #51998

Closed
2 tasks done
Centril opened this issue Jul 2, 2018 · 8 comments
Closed
2 tasks done

Tracking issue for RFC 2296, Option::replace #51998

Centril opened this issue Jul 2, 2018 · 8 comments
Labels
B-RFC-implemented Blocker: Approved by a merged RFC and implemented. B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Jul 2, 2018 •
edited
Loading

This is a tracking issue for the RFC "Add Option::replace to the core library" (rust-lang/rfcs#2296).

Steps:

Unresolved questions:

None
@Centril Centril added B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. labels Jul 2, 2018
@Centril Centril mentioned this issue Jul 2, 2018
Merged
@Kerollmops Kerollmops mentioned this issue Jul 2, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Jul 12, 2018
@kennytm
Rollup merge of rust-lang#52003 - Kerollmops:option-replace, r=Kimundi
e2683f2 
Implement `Option::replace` in the core library

Here is the implementation of the `Option::replace` method. The first step of [the tracking issue rust-lang#51998](rust-lang#51998).
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jul 13, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#52003 - Kerollmops:option-replace, r=Kimundi
20176fe 
Implement `Option::replace` in the core library

Here is the implementation of the `Option::replace` method. The first step of [the tracking issue rust-lang#51998](rust-lang#51998).
kennytm added a commit to kennytm/rust that referenced this issue Jul 13, 2018
@kennytm
Rollup merge of rust-lang#52003 - Kerollmops:option-replace, r=Kimundi
a2c3713 
Implement `Option::replace` in the core library

Here is the implementation of the `Option::replace` method. The first step of [the tracking issue rust-lang#51998](rust-lang#51998).
@varkor varkor added B-RFC-implemented Blocker: Approved by a merged RFC and implemented. and removed B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels Jul 29, 2018
@Centril Centril added the B-unstable Blocker: Implemented in the nightly compiler and unstable. label Sep 18, 2018
@Centril
Copy link
Contributor Author

Centril commented Sep 18, 2018

cc @SimonSapin this has baked in nightly for roughly 9.5 weeks; should we stabilize?

@SimonSapin
Copy link
Contributor

Looks good to me.

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Sep 18, 2018 •
edited by Kimundi
Loading

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 18, 2018
@rfcbot
Copy link

rfcbot commented Sep 19, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Sep 19, 2018
@rfcbot
Copy link

rfcbot commented Sep 29, 2018

The final comment period, with a disposition to merge, as per the review above, is now complete.

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 29, 2018
@Centril
Copy link
Contributor Author

Centril commented Oct 7, 2018

@Kerollmops would you be willing to write up a stabilization PR?

@Centril Centril mentioned this issue Oct 7, 2018
Closed
@Kerollmops
Copy link
Contributor

Yes, I will do that !

@Kerollmops Kerollmops mentioned this issue Oct 8, 2018
Merged
pietroalbini added a commit to pietroalbini/rust that referenced this issue Oct 9, 2018
@pietroalbini
Rollup merge of rust-lang#54904 - Kerollmops:stabilize-option-replace…
2f3569b 
…, r=Centril

Stabilize the `Option::replace` method

This PR stabilize the `Option::replace` method propose in rust-lang#51998.
pietroalbini added a commit to pietroalbini/rust that referenced this issue Oct 10, 2018
@pietroalbini
Rollup merge of rust-lang#54904 - Kerollmops:stabilize-option-replace…
12db9d2 
…, r=Centril

Stabilize the `Option::replace` method

This PR stabilize the `Option::replace` method propose in rust-lang#51998.
@Centril
Copy link
Contributor Author

Centril commented Oct 31, 2018

I believe there's nothing more left to do; closing therefore.

@Centril Centril closed this as completed Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-implemented Blocker: Approved by a merged RFC and implemented. B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@SimonSapin @Centril @Kerollmops @varkor @rfcbot