Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate rustc-ap-syntax in the RLS #53006

Closed
alexcrichton opened this issue Aug 2, 2018 · 2 comments
Closed

Deduplicate rustc-ap-syntax in the RLS #53006

alexcrichton opened this issue Aug 2, 2018 · 2 comments

Comments

@alexcrichton
Copy link
Member

As of #52919 we'll be updating to a version of the RLS which depends on racer which depends on rustc-ap-syntax. Unfortunately we're bringing in two different versions of rustc-ap-syntax, 209 and 211, right now.

These should be deduplicated as they take a good deal of time to build on CI, and then we should also add a tidy check which ensures that there's only one version of rustc-ap-syntax in our workspace.

cc @nrc

@alexcrichton
Copy link
Member Author

I've sent a PR to update racer as part of racer-rust/racer#915

@nrc
Copy link
Member

nrc commented Aug 8, 2018

This is fixed by #53141

alexcrichton added a commit to alexcrichton/rust that referenced this issue Aug 9, 2018
Enable the tidy check to forbid this!

Closes rust-lang#53006
kennytm added a commit to kennytm/rust that referenced this issue Aug 11, 2018
Deny future duplication of rustc-ap-syntax

Enable the tidy check to forbid this!

Closes rust-lang#53006
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 12, 2018
Deny future duplication of rustc-ap-syntax

Enable the tidy check to forbid this!

Closes rust-lang#53006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants