Rename *San libraries when distributing #54134
Labels
A-sanitizers
Area: Sanitizers for correctness and code quality.
Comments
alexcrichton
added
the
A-sanitizers
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this issue
Sep 29, 2018
Currently we ship sanitizer libraries as they're built, but these names unfortunately conflict with the names of the sanitizer libraries installed on the system. If a crate, for example, links in C code that wants to use the system sanitizer and the Rust code doesn't use sanitizers at all, then using `cargo` may accidentally pull in the Rust-installed sanitizer library due to a conflict in names. This change is intended to be entirely transparent for Rust users of sanitizers, it should only hopefully improve our story with other users! Closes rust-lang#54134
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Oct 1, 2018
Rename sanitizer runtime libraries on OSX Currently we ship sanitizer libraries as they're built, but these names unfortunately conflict with the names of the sanitizer libraries installed on the system. If a crate, for example, links in C code that wants to use the system sanitizer and the Rust code doesn't use sanitizers at all, then using `cargo` may accidentally pull in the Rust-installed sanitizer library due to a conflict in names. This change is intended to be entirely transparent for Rust users of sanitizers, it should only hopefully improve our story with other users! Closes rust-lang#54134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discovered in https://trac.torproject.org/projects/tor/ticket/27274#comment:7 it turns out that our vendored copies of these libraires cause problems when they override the system versions by accident. We should rename our copies with a Rust-specific name to avoid this name clash.
The text was updated successfully, but these errors were encountered: