Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os_str_str_ref_eq feature marked stable since 1.28.0 instead of 1.29.0 #54195

Closed
mmerickel opened this issue Sep 13, 2018 · 0 comments
Closed

os_str_str_ref_eq feature marked stable since 1.28.0 instead of 1.29.0 #54195

mmerickel opened this issue Sep 13, 2018 · 0 comments

Comments

@mmerickel
Copy link

I noticed that https://blog.rust-lang.org/2018/09/13/Rust-1.29.html mentioned #51178 and it is marked #[stable(feature = "os_str_str_ref_eq", since = "1.28.0")]. Shouldn't that be 1.29.0?

https://github.com/rust-lang/rust/blob/1.29.0/src/libstd/ffi/os_str.rs#L420-L432
@cuviper cuviper mentioned this issue Sep 13, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Sep 14, 2018
@kennytm
Rollup merge of rust-lang#54203 - cuviper:stable-os_str_str_ref_eq, r…
ae8410b 
…=estebank

Fix the stable release of os_str_str_ref_eq

This was added and stabilized in commit 0250302, but while that
claimed to be for 1.28.0, it didn't actually make it until 1.29.0.

Fixes rust-lang#54195.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mmerickel