Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for feature extern_in_paths #55600

Closed
petrochenkov opened this issue Nov 1, 2018 · 5 comments · Fixed by #57572
Closed

Tracking issue for feature extern_in_paths #55600

petrochenkov opened this issue Nov 1, 2018 · 5 comments · Fixed by #57572
Labels
A-rust-2018-preview Area: The 2018 edition preview B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-close This PR / issue is in PFCP or FCP with a disposition to close it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@petrochenkov
Copy link
Contributor

Allows using extern in paths to unambiguously refer to items in extern crates - extern::my_crate::foo.

This feature is superseded by absolute paths ::my_crate::foo on 2018 edition, and has little value on 2015 edition where extern crate items are supposed to be used instead.
As a result, the feature is supposed to be removed once 2018 edition ships.
@petrochenkov petrochenkov added T-lang Relevant to the language team, which will review and decide on the PR/issue. B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. A-rust-2018-preview Area: The 2018 edition preview labels Nov 1, 2018
@Centril
Copy link
Contributor

Centril commented Nov 10, 2018

@rfcbot close

Per @petrochenkov's notes above I propose that we remove extern:: once the 2018 edition has shipped.

@rfcbot
Copy link

rfcbot commented Nov 10, 2018 •
edited by pnkfelix
Loading

Team member @Centril has proposed to close this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-close This PR / issue is in PFCP or FCP with a disposition to close it. labels Nov 10, 2018
@rfcbot
Copy link

rfcbot commented Nov 30, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Nov 30, 2018
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 10, 2018
@rfcbot
Copy link

rfcbot commented Dec 10, 2018

The final comment period, with a disposition to close, as per the review above, is now complete.

@Centril
Copy link
Contributor

Centril commented Dec 10, 2018

@petrochenkov Now that FCP is complete, could you either 1) write up mentoring instructions, 2) fix it up yourself? :)

@Centril Centril mentioned this issue Jan 13, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Jan 14, 2019
@Centril
Rollup merge of rust-lang#57572 - Centril:unaccept-extern-in-path, r=…
9f52fbb 
…petrochenkov

Unaccept `extern_in_paths`

Based on completed fcp-close in rust-lang#55600, this removes `extern_in_path` (e.g. `extern::foo::bar`) from the language. The changes are primarily reversing rust-lang@32db83b.

Closes rust-lang#55600

r? @petrochenkov
Centril added a commit to Centril/rust that referenced this issue Jan 14, 2019
@Centril
Rollup merge of rust-lang#57572 - Centril:unaccept-extern-in-path, r=…
feb48f3 
…petrochenkov

Unaccept `extern_in_paths`

Based on completed fcp-close in rust-lang#55600, this removes `extern_in_path` (e.g. `extern::foo::bar`) from the language. The changes are primarily reversing rust-lang@32db83b.

Closes rust-lang#55600

r? @petrochenkov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rust-2018-preview Area: The 2018 edition preview B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-close This PR / issue is in PFCP or FCP with a disposition to close it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unaccept extern_in_paths Centril/rust
3 participants
@Centril @petrochenkov @rfcbot