Dependency check of the tidy tool should verify libstd dependencies #62619
Labels
A-runtime
Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-bug
Category: This is a bug.
Comments
jonas-schievink
added
A-runtime
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Mar 17, 2020
…mulacrum tidy: Better license checks. This implements some improvements to the license checks in tidy: * Use `cargo_metadata` instead of parsing vendored crates. This allows license checks to run without vendoring enabled, and allows the checks to run on PR builds. * Check for stale entries. * Check that the licenses for exceptions are what we think they are. * Verify exceptions do not leak into the runtime. Closes rust-lang#62618 Closes rust-lang#62619 Closes rust-lang#63238 (I think) There are some substantive changes here. The follow licenses have changed from the original comments: * openssl BSD+advertising clause to Apache-2.0 * pest MPL2 to MIT/Apache-2.0 * smallvec MPL2 to MIT/Apache-2.0 * clippy lints MPL2 to MIT OR Apache-2.0
Centril
added a commit
to Centril/rust
that referenced
this issue
Mar 19, 2020
…mulacrum tidy: Better license checks. This implements some improvements to the license checks in tidy: * Use `cargo_metadata` instead of parsing vendored crates. This allows license checks to run without vendoring enabled, and allows the checks to run on PR builds. * Check for stale entries. * Check that the licenses for exceptions are what we think they are. * Verify exceptions do not leak into the runtime. Closes rust-lang#62618 Closes rust-lang#62619 Closes rust-lang#63238 (I think) There are some substantive changes here. The follow licenses have changed from the original comments: * openssl BSD+advertising clause to Apache-2.0 * pest MPL2 to MIT/Apache-2.0 * smallvec MPL2 to MIT/Apache-2.0 * clippy lints MPL2 to MIT OR Apache-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a documentation comment explicitly saying that it is crucial for libcore,liballoc,libstd not to depend on any crate with incompatible licenses, yet a couple of lines after there is an exemption that does precisely this: https://github.com/rust-lang/rust/blob/master/src/tools/tidy/src/deps.rs#L25
AFAICT, this property of the runtime is not verified by the tidy script, but should.
The text was updated successfully, but these errors were encountered: