Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: "changelog-seen = 1" breaks config.toml #77105

Closed
matthiaskrgr opened this issue Sep 23, 2020 · 1 comment · Fixed by #77106
Closed

rustbuild: "changelog-seen = 1" breaks config.toml #77105

matthiaskrgr opened this issue Sep 23, 2020 · 1 comment · Fixed by #77106
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Sep 23, 2020 •
edited
Loading 

warning: x.py has made several changes recently you may want to look at
help: consider looking at the changes in `src/bootstrap/CHANGELOG.md`
note: to silence this warning, add `changelog-seen = 1` to `config.toml`

So I skipped through the changelog and added changelog-seen = 1 to the end of my config toml but this broke x.py:

failed to parse TOML configuration 'config.toml': unknown field `changelog-seen`, expected one of `sign-folder`, `gpg-password-file`, `upload-addr`, `src-tarball`, `missing-tools` for key `dist` at line 522 column 1
@matthiaskrgr matthiaskrgr added the C-bug Category: This is a bug. label Sep 23, 2020
@matthiaskrgr
Copy link
Member Author

Apparently the script wants it at the beginning of the toml file, the warning message should says so 🙄

@matthiaskrgr matthiaskrgr mentioned this issue Sep 23, 2020
Merged
@jyn514 jyn514 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 23, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Sep 24, 2020
@Dylan-DPC
Rollup merge of rust-lang#77106 - matthiaskrgr:changelog_seen, r=Mark…
feb6392 
…-Simulacrum

clarify that `changelog-seen = 1` goes to the beginning of config.toml

Fixes rust-lang#77105
RalfJung added a commit to RalfJung/rust that referenced this issue Sep 25, 2020
@RalfJung
Rollup merge of rust-lang#77106 - matthiaskrgr:changelog_seen, r=Mark…
a6d54fa 
…-Simulacrum

clarify that `changelog-seen = 1` goes to the beginning of config.toml

Fixes rust-lang#77105
RalfJung added a commit to RalfJung/rust that referenced this issue Sep 25, 2020
@RalfJung
Rollup merge of rust-lang#77106 - matthiaskrgr:changelog_seen, r=Mark…
838cb36 
…-Simulacrum

clarify that `changelog-seen = 1` goes to the beginning of config.toml

Fixes rust-lang#77105
@bors bors closed this as completed in b5d47bf Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clarify that changelog-seen = 1 goes to the beginning of config.toml matthiaskrgr/rust
2 participants
@matthiaskrgr @jyn514