Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forwarding functions (from object coercions) should tail-call target #80

Closed
graydon opened this issue Jun 28, 2010 · 2 comments
Closed

Forwarding functions (from object coercions) should tail-call target #80

graydon opened this issue Jun 28, 2010 · 2 comments

Comments

@graydon
Copy link
Contributor

graydon commented Jun 28, 2010

When we do an 'as' operation to build a new obj with a different-shaped vtbl, we currently use a vtbl full of forwarding functions (to make the cast constant-time). The forwarding functions (if we continue to use them) should end in tali-calls, not normal calls. Same as with closure helpers.
@graydon
Copy link
Contributor Author

graydon commented Jan 27, 2011

Shifted to rustc

@marijnh
Copy link
Contributor

marijnh commented Jan 13, 2012

No longer relevant.

@marijnh marijnh closed this as completed Jan 13, 2012
@evanmcc evanmcc mentioned this issue Apr 3, 2012
Closed
@lilyball lilyball mentioned this issue Jul 22, 2014
Closed
@tuttle tuttle mentioned this issue Apr 4, 2015
Closed
oli-obk pushed a commit to oli-obk/rust that referenced this issue Jul 19, 2017
@solson
Merge pull request rust-lang#80 from plietar/signed-discriminant
ea7db14 
Read discriminant as a signed integer.
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@alexcrichton
Merge pull request rust-lang#80 from semarie/librt
867c6ff 
unbreak openbsd and bitrig due to linking to rt
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
@steveklabnik
Merge pull request rust-lang#80 from daghenrik/patch-1
296d1d9 
Update attributes.md
@venkag venkag mentioned this issue Feb 13, 2019
Closed
eddyb pushed a commit to eddyb/rust that referenced this issue Jun 30, 2020
@ibabushkin
Merge pull request rust-lang#80 from gnzlbg/soft
2b16f74 
Add flag --api-guidelines to silence non-technical breaking changes.
bors pushed a commit to rust-lang-ci/rust that referenced this issue Oct 1, 2021
@workingjubilee
Merge pull request rust-lang#80 from rust-lang/feature/comparisons
0682c31 
Add classification functions
@Amanieu Amanieu mentioned this issue Jun 12, 2023
Open
jaisnan added a commit to jaisnan/rust-dev that referenced this issue Sep 6, 2024
@jaisnan
Prevent skipping due to "if" statement (rust-lang#80)
e29fb31 
Prevent pr approval from getting skipped when there is a non-approval
review submitted on the PR.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graydon @marijnh