Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make TypeError impl Copy #100510

Merged
merged 1 commit into from
Aug 15, 2022
Merged

make TypeError impl Copy #100510

merged 1 commit into from
Aug 15, 2022

Conversation

compiler-errors
Copy link
Member

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 13, 2022
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 13, 2022
@bors
Copy link
Contributor

bors commented Aug 13, 2022

⌛ Trying commit 1db3aa124b625c40f02f6aa9d54e987193557eef with merge e1fce0925985ca02299b27bba245048945cd0b22...

@bors
Copy link
Contributor

bors commented Aug 13, 2022

☀️ Try build successful - checks-actions
Build commit: e1fce0925985ca02299b27bba245048945cd0b22 (e1fce0925985ca02299b27bba245048945cd0b22)

@rust-timer
Copy link
Collaborator

Queued e1fce0925985ca02299b27bba245048945cd0b22 with parent 75b7e52, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e1fce0925985ca02299b27bba245048945cd0b22): comparison url.

Instruction count

  • Primary benchmarks: ❌ relevant regressions found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions ❌
(primary)		 0.9% 1.0% 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.9% 1.0% 2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: ✅ relevant improvements found
mean1 max count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.1% -5.7% 2
All ❌✅ (primary) - - 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 13, 2022
@compiler-errors
Copy link
Member Author

Uh, I wonder if this is noise.

@rust-timer build e1fce0925985ca02299b27bba245048945cd0b22

@compiler-errors
Copy link
Member Author

Ugh, can't re-run rust-timer? :s

@compiler-errors
Copy link
Member Author

I'm gonna try one more time to see if that was just noise

@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 14, 2022
@bors
Copy link
Contributor

bors commented Aug 14, 2022

⌛ Trying commit b1787a678fbdb1e41717dd82032f3efd74399b06 with merge 1a017b030381225228ca0969ae778585d8d213f7...

@bors
Copy link
Contributor

bors commented Aug 14, 2022

☀️ Try build successful - checks-actions
Build commit: 1a017b030381225228ca0969ae778585d8d213f7 (1a017b030381225228ca0969ae778585d8d213f7)

@rust-timer
Copy link
Collaborator

Queued 1a017b030381225228ca0969ae778585d8d213f7 with parent d70c0ec, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1a017b030381225228ca0969ae778585d8d213f7): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: ✅ relevant improvement found
mean1 max count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% -0.2% 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions ❌
(primary)		 0.5% 0.5% 1
Regressions ❌
(secondary)		 3.3% 3.4% 2
Improvements ✅
(primary)		 -2.3% -2.3% 1
Improvements ✅
(secondary)		 -3.3% -3.5% 2
All ❌✅ (primary) -0.9% -2.3% 2

Cycles

Results
  • Primary benchmarks: ❌ relevant regression found
  • Secondary benchmarks: ❌ relevant regression found
mean1 max count2
Regressions ❌
(primary)		 2.1% 2.1% 1
Regressions ❌
(secondary)		 3.2% 3.2% 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.1% 2.1% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 14, 2022
@compiler-errors
Copy link
Member Author

so it was just noise 💢

@compiler-errors
Copy link
Member Author

r? compiler

@compiler-errors compiler-errors marked this pull request as ready for review August 14, 2022 17:16
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 14, 2022

📌 Commit b1787a678fbdb1e41717dd82032f3efd74399b06 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2022
@jackh726
Copy link
Member

@bors r-
needs rebase

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 14, 2022
@compiler-errors
Copy link
Member Author

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Aug 14, 2022

📌 Commit 75dfe55 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 14, 2022
@compiler-errors compiler-errors mentioned this pull request Aug 14, 2022
Merged
@bors
Copy link
Contributor

bors commented Aug 15, 2022

⌛ Testing commit 75dfe55 with merge 76c427d...

@bors
Copy link
Contributor

bors commented Aug 15, 2022

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 76c427d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 15, 2022
@bors bors merged commit 76c427d into rust-lang:master Aug 15, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 15, 2022
@bors bors mentioned this pull request Aug 15, 2022
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (76c427d): comparison url.

Instruction count

  • Primary benchmarks: ❌ relevant regression found
  • Secondary benchmarks: ❌ relevant regression found
mean1 max count2
Regressions ❌
(primary)		 1.0% 1.0% 1
Regressions ❌
(secondary)		 0.2% 0.2% 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.0% 1.0% 1

Max RSS (memory usage)

Results
  • Primary benchmarks: ❌ relevant regressions found
  • Secondary benchmarks: ✅ relevant improvements found
mean1 max count2
Regressions ❌
(primary)		 4.7% 7.0% 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.9% -3.4% 2
All ❌✅ (primary) 4.7% 7.0% 2

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: ✅ relevant improvement found
mean1 max count2
Regressions ❌
(primary)		 3.4% 3.4% 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.6% -3.3% 2
Improvements ✅
(secondary)		 -7.0% -7.0% 1
All ❌✅ (primary) -0.6% 3.4% 3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@compiler-errors compiler-errors deleted the as-a-treat branch August 11, 2023 19:55
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rust-timer @bors @jackh726 @rustbot