Kind-less SessionDiagnostic derive

[Xiretza]

From #100730 (comment):

Hm, maybe we should expose some sess.struct_$SOMETHING (like struct_diagnostic?) that is generic over EmissionGuarantee, then make the SessionDiagnostic derive generic, i.e.

impl<'tcx> SessionDiagnostic for UnusedGenericParams {
  fn into_diagnostic<T: EmissionGuarantee>( .. ) -> DiagnosticBuilder<'tcx, T> {
    let mut diag = sess.struct_diagnostic(rustc_errors:..);
    ..
  }
}

Discussed on Zulip.

[rust-highfive]

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

[rustbot]

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank

[compiler-errors]

r? @compiler-errors

[compiler-errors]

This is exactly what I wanted to see! 😄 I'll wait until CI is ready and then approve.

[compiler-errors]

Also, we probably need to adjust the rustc dev guide docs once again.

[Xiretza]

That's good to hear! :D The PR will conflict with all the diagnostics migration PRs currently open, so I suppose it will need a rollup=never with a relatively high priority or it'll fail bors until the end of time.

[Xiretza]

Also, we probably need to adjust the rustc dev guide docs once again.

Already drafted: rust-lang/rustc-dev-guide#1440

[compiler-errors]

The PR will conflict with all the diagnostics migration PRs currently open, so I suppose it will need a rollup=never with a relatively high priority or it'll fail bors until the end of time.

Yup makes sense. I was gonna wait until CI is green then approve.

Already drafted: rust-lang/rustc-dev-guide#1440

You're wonderful!

[compiler-errors]

@bors r+ p=1 rollup=never

(will likely not merge unless p=1)

[bors]

📌 Commit 450989f9ede869f8e432f9c1f64d3d055bfa041a has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 450989f9ede869f8e432f9c1f64d3d055bfa041a with merge 8175a9f41cc3944935dcc70a5eb751ffc371d3a9...

[ChrisDenton]

CI has stalled.

EDIT: Sorry for the noise. The CI was still going after 5hrs without movement from a Windows builder for at least 3hrs.

[compiler-errors]

Wait... this needs rebase.

@bors r-

[compiler-errors]

@bors r+

[bors]

📌 Commit 7f3a6fd has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7f3a6fd with merge 4b695f7...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 4b695f7 to master...

[rust-timer]

Finished benchmarking commit (4b695f7): comparison url.

Instruction count

• Primary benchmarks: ✅ relevant improvements found
• Secondary benchmarks: no relevant changes found

	mean1	max	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	-0.9%	5
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.8%	-0.9%	5

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	2.9%	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	-3.3%	2
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[davidtwco]

Thanks for working on this!