Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial version of 1.64 release notes #101093

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Initial version of 1.64 release notes #101093

merged 1 commit into from
Sep 18, 2022

Conversation

joshtriplett
Copy link
Member

Needs further expansion on some points, with text that will likely end up in
the blog post as well.

Also adds the release notes from 1.62.1 and 1.63, which weren't present on the
branch.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2022
@Mark-Simulacrum Mark-Simulacrum added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Aug 27, 2022
tshepang
tshepang reviewed Aug 27, 2022
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
CryZe
CryZe reviewed Aug 27, 2022
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
@tmandry
Copy link
Member

tmandry commented Sep 2, 2022

@joshtriplett I added some things as discussed in Zulip, please take a look

joshtriplett
joshtriplett commented Sep 2, 2022
View reviewed changes
RELEASES.md Outdated Show resolved Hide resolved
@joshtriplett
Copy link
Member Author

@tmandry Thanks!

@marmeladema
Copy link
Contributor

According to #101822, the change in #99413 introduced a known backward incompatible change.
Should there be a dedicated section for such thing in the release note?

I am not arguing that the change should or should not have landed. That is way beyond my knowledge. But having this mentioned would be valuable for others so that they don't spend time minimizing and trying to figure out what is happening 😁

@ehuss
Copy link
Contributor

ehuss commented Sep 14, 2022

Should there be a dedicated section for such thing in the release note?

There is a dedicated section "Compatibility Notes". #99413 is listed twice, there and the libs section.

@marmeladema
Copy link
Contributor

There is a dedicated section "Compatibility Notes". #99413 is listed twice, there and the libs section.

Sure but

- [Add `PhantomData` marker for dropck to `BTreeMap`](https://github.com/rust-lang/rust/pull/99413/)

doesn't really mean anything to users outside of compiler contributors.
I was thinking of something more user understandable to regular rust programmers.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup p=1

@bors
Copy link
Contributor

bors commented Sep 17, 2022

📌 Commit 25e2091 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2022
@marmeladema
Copy link
Contributor

Thank you very much @tmandry ! The details you added are great 👍

pthariensflame
pthariensflame reviewed Sep 17, 2022
View reviewed changes
RELEASES.md
Stabilized APIs
---------------

- [`ffi::CStr`](https://doc.rust-lang.org/stable/std/ffi/struct.CStr.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would these not be clearer as core::ffi::… so that it’s obvious the “new” part is being in core?

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#101093 - joshtriplett:relnotes-1.64, r=Mark…
f3b1c2c 
…-Simulacrum

Initial version of 1.64 release notes

Needs further expansion on some points, with text that will likely end up in
the blog post as well.

Also adds the release notes from 1.62.1 and 1.63, which weren't present on the
branch.
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 17, 2022
Closed
@matthiaskrgr
Copy link
Member

@bors rollup=never
please don't mark beta-branch prs as rollup=always 😅

@Mark-Simulacrum Mark-Simulacrum changed the base branch from beta to master September 17, 2022 17:44
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 17, 2022
@bors
Copy link
Contributor

bors commented Sep 17, 2022

⚠️ The base branch changed to master, and the PR will need to be re-approved.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2022
@bors
Copy link
Contributor

bors commented Sep 17, 2022

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum @tmandry @joshtriplett
Release notes update
a924b8a 
Co-authored-by: Tyler Mandry <tmandry@gmail.com>
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
@Mark-Simulacrum
Copy link
Member

This ... shouldn't be targeted at the beta branch, not sure why that was done. Release notes should always target the master branch.

I've changed the base branch and squashed the commits while rebasing since that was easier than getting git to move just the right commits over.

@bors r+ rollup p=1

@bors
Copy link
Contributor

bors commented Sep 17, 2022

📌 Commit a924b8a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 17, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 17, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 17, 2022
@bors
Auto merge of rust-lang#101949 - matthiaskrgr:rollup-xu5cqnd, r=matth…
5253b0a 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#101093 (Initial version of 1.64 release notes)
 - rust-lang#101713 (change AccessLevels representation)
 - rust-lang#101821 (Bump Unicode to version 15.0.0, regenerate tables)
 - rust-lang#101826 (Enforce "joined()" and "joined_with_noop()" test)
 - rust-lang#101835 (Allow using vendoring when running bootstrap from outside the source root)
 - rust-lang#101942 (Revert "Copy stage0 binaries into stage0-sysroot")
 - rust-lang#101943 (rustdoc: remove unused CSS `.non-exhaustive { margin-bottom }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8362321 into rust-lang:master Sep 18, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 18, 2022
@bors
Copy link
Contributor

bors commented Sep 18, 2022

⌛ Testing commit a924b8a with merge 5253b0a...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshepang tshepang tshepang left review comments

@CryZe CryZe CryZe left review comments

@pthariensflame pthariensflame pthariensflame left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.