Fix ICE in opt_suggest_box_span

[compiler-errors]

We were totally mishandling substs and obligations in opt_suggest_box_span, so I reworked that function pretty heavily.

Also some drive-by changes, namely removing ret_type_span.

Fixes #101465

[rust-highfive]

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

[lcnr]

one nit, then r=me

[compiler-errors]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 5599a45 with merge 3e9e52a97e7a94c5be229f2f1bdc5582aa3123f4...

[bors]

☀️ Try build successful - checks-actions
Build commit: 3e9e52a97e7a94c5be229f2f1bdc5582aa3123f4 (3e9e52a97e7a94c5be229f2f1bdc5582aa3123f4)

[rust-timer]

Queued 3e9e52a97e7a94c5be229f2f1bdc5582aa3123f4 with parent 98e1f04, future comparison URL.

[rust-timer]

Finished benchmarking commit (3e9e52a97e7a94c5be229f2f1bdc5582aa3123f4): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	4.6%	[3.7%, 5.5%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.4%	[-3.6%, -3.2%]	2
Improvements ✅ (secondary)	-1.5%	[-2.3%, -0.6%]	2
All ❌✅ (primary)	0.6%	[-3.6%, 5.5%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.4%	[2.4%, 2.4%]	1
Regressions ❌ (secondary)	4.8%	[4.8%, 4.8%]	1
Improvements ✅ (primary)	-3.9%	[-5.3%, -2.3%]	4
Improvements ✅ (secondary)	-3.6%	[-3.9%, -3.4%]	2
All ❌✅ (primary)	-2.6%	[-5.3%, 2.4%]	5

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[lcnr]

@bors r+

[bors]

📌 Commit 5599a45 has been approved by lcnr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 5599a45 with merge a93214e...

[bors]

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing a93214e to master...

[rust-timer]

Finished benchmarking commit (a93214e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.2%	[-5.2%, -5.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.9%	[1.4%, 2.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean1	range	count2
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.4%	[-3.4%, -3.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-3.4%, 2.2%]	2

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³