Adding needs-unwind arg to applicable compiler ui tests #101741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
These are compiler ui tests I believe that require unwind (i.e. not cc. @djkoloski @tmandry |
andrewpollack
force-pushed
the
add-needs-unwind-ui-tests
branch
from
855278c
to
4f18358
Compare
djkoloski
suggested changes
Sep 13, 2022
| @@ -12,6 +12,7 @@ | |||
| // edition:2018 | |||
| // ignore-wasm32 issue #62807 | |||
| // ignore-asmjs issue #62807 | |||
| // needs-unwind Closures off by one byte due to panic byte flag required | |||
andrewpollack
force-pushed
the
add-needs-unwind-ui-tests
branch
from
4f18358
to
34a57a2
Compare
|
Removed tests that require further inspection -- revisiting those in separate PR |
tmandry
reviewed
Sep 14, 2022
andrewpollack
force-pushed
the
add-needs-unwind-ui-tests
branch
from
34a57a2
to
ac54767
Compare
|
@bors delegate+ rollup |
|
✌️ @andrewpollack can now approve this pull request |
andrewpollack
force-pushed
the
add-needs-unwind-ui-tests
branch
from
ac54767
to
5d27f19
Compare
|
@bors r=tmandry |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 17, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#101340 (Adding Fuchsia zxdb debugging walkthrough to docs) - rust-lang#101741 (Adding needs-unwind arg to applicable compiler ui tests) - rust-lang#101782 (Update `symbol_mangling` diagnostics migration) - rust-lang#101878 (More simple formatting) - rust-lang#101898 (Remove some unused CSS rules) - rust-lang#101911 (rustdoc: remove no-op CSS on `.source .content`) - rust-lang#101914 (rustdoc-json-types: Document that ResolvedPath can also be a union) - rust-lang#101921 (Pass --cfg=bootstrap for rustdoc for proc_macro crates) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
needs-unwindarg to applicable compiler ui tests