-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asm: Match clang behavior for inlateout fixed register operands #103098
Conversation
We have 2 options for representing LLVM constraints for `inlateout` operands on a fixed register (e.g. `r0`): `={r0},0` or `={r0},{r0}`. This PR changes the behavior to the latter, which matches the behavior of Clang since https://reviews.llvm.org/D87279.
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
I don't know enough about asm to review this, sorry. |
Likewise, maybe bjorn? r? @bjorn3 |
I don't know enough about LLVM to know why this would be beneficial/necessary, but it doesn't look like it would break anything either. @bors r+ |
⌛ Testing commit 6bfe7f0 with merge 41812cc416495286dabb10d5270c92cc0b6c9e7f... |
💔 Test failed - checks-actions |
Network error |
☀️ Test successful - checks-actions |
Finished benchmarking commit (47c008e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
asm: Match clang behavior for inlateout fixed register operands We have 2 options for representing LLVM constraints for `inlateout` operands on a fixed register (e.g. `r0`): `={r0},0` or `={r0},{r0}`. This PR changes the behavior to the latter, which matches the behavior of Clang since https://reviews.llvm.org/D87279.
We have 2 options for representing LLVM constraints for
inlateout
operands on a fixed register (e.g.r0
):={r0},0
or={r0},{r0}
.This PR changes the behavior to the latter, which matches the behavior of Clang since https://reviews.llvm.org/D87279.