Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rustdoc Item::visibility computed on-demand #103690

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Make rustdoc Item::visibility computed on-demand #103690

merged 1 commit into from
Nov 2, 2022

Conversation

GuillaumeGomez
Copy link
Member

This is a take-over of #91408.

Helps with #90852 (needs to use ty::Visibility directly too).

cc @camelid
r? @notriddle

@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 28, 2022
@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2022

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@GuillaumeGomez
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 28, 2022
@bors
Copy link
Contributor

bors commented Oct 28, 2022

⌛ Trying commit 424e1997e89252ee856e4b11a4bbf10c88907b7e with merge ecfa207ec942b47e92e5f303e4f8384c6cf14ace...

@bors
Copy link
Contributor

bors commented Oct 28, 2022

☀️ Try build successful - checks-actions
Build commit: ecfa207ec942b47e92e5f303e4f8384c6cf14ace (ecfa207ec942b47e92e5f303e4f8384c6cf14ace)

@rust-timer
Copy link
Collaborator

Queued ecfa207ec942b47e92e5f303e4f8384c6cf14ace with parent a9ef100, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ecfa207ec942b47e92e5f303e4f8384c6cf14ace): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)		 -0.7% [-1.5%, -0.3%] 15
Improvements ✅
(secondary)		 -1.1% [-1.6%, -0.3%] 21
All ❌✅ (primary) -0.7% [-1.5%, -0.3%] 15

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)		 -3.7% [-3.7%, -3.7%] 1
All ❌✅ (primary) -1.4% [-1.4%, -1.4%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.5% [-2.9%, -2.1%] 2
Improvements ✅
(secondary)		 -2.9% [-3.2%, -2.7%] 12
All ❌✅ (primary) -2.5% [-2.9%, -2.1%] 2

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 29, 2022
@GuillaumeGomez
Copy link
Member Author

@bors r=notriddle rollup=iffy

@bors
Copy link
Contributor

bors commented Oct 29, 2022

📌 Commit fd6d7fef6e955e6418c69e8041b5102eda0fe3fd has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2022
@bors
Copy link
Contributor

bors commented Oct 29, 2022

☔ The latest upstream changes (presumably #103727) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 29, 2022
@rustbot

This comment was marked as resolved.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

@bors r=notriddle rollup=iffy

@bors
Copy link
Contributor

bors commented Oct 30, 2022

📌 Commit 81f5d1d6bc25af376f8eb89994f9dac1318c0250 has been approved by notriddle

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 30, 2022
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 30, 2022
@bors
Copy link
Contributor

bors commented Oct 30, 2022

☔ The latest upstream changes (presumably #103010) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 30, 2022
@GuillaumeGomez
Copy link
Member Author

@bors r=notriddle rollup=iffy

@bors
Copy link
Contributor

bors commented Oct 30, 2022

📌 Commit 5515e2c has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2022
@bors
Copy link
Contributor

bors commented Nov 2, 2022

⌛ Testing commit 5515e2c with merge c0a7612...

@bors
Copy link
Contributor

bors commented Nov 2, 2022

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing c0a7612 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 2, 2022
@bors bors merged commit c0a7612 into rust-lang:master Nov 2, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 2, 2022
@GuillaumeGomez GuillaumeGomez deleted the visibility-on-demand branch November 2, 2022 14:37
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c0a7612): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.7% [-1.7%, -0.2%] 14
Improvements ✅
(secondary)		 -1.5% [-2.7%, -0.6%] 25
All ❌✅ (primary) -0.7% [-1.7%, -0.2%] 14

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.3% [2.3%, 2.3%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.0% [-1.0%, -1.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.6% [-1.0%, 2.3%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)		 -2.2% [-2.5%, -2.1%] 11
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 3, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 4, 2022
@matthiaskrgr
Rollup merge of rust-lang#103935 - GuillaumeGomez:remove-rustdoc-visi…
c6e5150 
…bility-ty, r=notriddle

Remove rustdoc clean::Visibility type

Fixes rust-lang#90852.

Follow-up of rust-lang#103690.

This PR completely removes the rustdoc `clean::Visibility` type to use the `rustc_middle` one instead. I don't think there will be any impact on perf.

r? `@notriddle`
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#103690 - GuillaumeGomez:visibility-on-demand,…
84e903f 
… r=notriddle

Make rustdoc Item::visibility computed on-demand

This is a take-over of rust-lang#91408.

Helps with rust-lang#90852 (needs to use `ty::Visibility` directly too).

cc `@camelid`
r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notriddle notriddle notriddle approved these changes

Assignees

@notriddle notriddle

Labels
A-rustdoc-json Area: Rustdoc JSON backend C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rustbot @rust-timer @bors @notriddle