Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate codegen_ssa to diagnostics structs - [Part 2] #103792

Merged
merged 5 commits into from
Nov 4, 2022
Merged

Migrate codegen_ssa to diagnostics structs - [Part 2] #103792

merged 5 commits into from
Nov 4, 2022

Commits on Nov 4, 2022

  1. UPDATE - Complete link.rs migration to new diagnostics infraestructure

    @JhonnyBillM
    JhonnyBillM committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    4c80f50 View commit details
    Browse the repository at this point in the history

  2. ADD - ExtractBundledLibsError. Migrated extract_bundled_libs to trans… 

    …latable diagnostics
    @JhonnyBillM
    JhonnyBillM committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    1f4c5a6 View commit details
    Browse the repository at this point in the history

  3. FIX - Migrate missing errors in link.rs

    @JhonnyBillM
    JhonnyBillM committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    2678765 View commit details
    Browse the repository at this point in the history

  4. UPDATE - address PR Comments 

    FIX - StrippingDebugInfoFailed typo

DELETE - unneeded FIXME comment

UPDATE - only declare the error with ExtractBundledLibsError as an enum and use the Diagnostic derive macro
    @JhonnyBillM
    JhonnyBillM committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    28491a7 View commit details
    Browse the repository at this point in the history

  5. UPDATE - accept dyn error and make Box<dyn error> conform to IntoDiag… 

    …nosticArg
    @JhonnyBillM
    JhonnyBillM committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    540c3f9 View commit details
    Browse the repository at this point in the history