Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce exceptions overallocation on non Windows x86_64 #104464

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Reduce exceptions overallocation on non Windows x86_64 #104464

merged 1 commit into from
Nov 22, 2022

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Nov 15, 2022 •
edited
Loading

Addressing #103894 (comment)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@thomcc
Copy link
Member

thomcc commented Nov 18, 2022

This took a while to verify, but seems fine. Thanks

@bors r+

@bors
Copy link
Contributor

bors commented Nov 18, 2022

📌 Commit 10d0f14 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Nov 22, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 22, 2022
@bors
Auto merge of rust-lang#104711 - Dylan-DPC:rollup-gkw1qr8, r=Dylan-DPC
66ccf36 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#104295 (Check generics parity before collecting return-position `impl Trait`s in trait)
 - rust-lang#104464 (Reduce exceptions overallocation on non Windows x86_64)
 - rust-lang#104615 (Create def_id for async fns during lowering)
 - rust-lang#104669 (Only declare bindings for if-let guards once per arm)
 - rust-lang#104701 (Remove a lifetime resolution hack from `compare_predicate_entailment`)
 - rust-lang#104710 (disable strict-provenance-violating doctests in Miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 20d6a44 into rust-lang:master Nov 22, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 22, 2022
@mati865 mati865 deleted the reduce-eh-overallocation-amd64 branch November 22, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mati865 @rustbot @thomcc @bors