Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "long type" printing type aware and trim types in E0275 #104469

Merged
merged 5 commits into from
Nov 19, 2022
Merged

Make "long type" printing type aware and trim types in E0275 #104469

merged 5 commits into from
Nov 19, 2022
+208 −97

Commits on Nov 18, 2022

  1. Make "long type" printing type aware 

    Instead of simple string cutting, use a custom printer to hide parts of
long printed types.
    @estebank
    estebank committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    d49c10a View commit details
    Browse the repository at this point in the history

  2. On overflow errors, do not print out long types

    @estebank
    estebank committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    787e633 View commit details
    Browse the repository at this point in the history

  3. On E0275 do not print out the full type in the msg 

    When printing requirement overflow errors, do not print out the full
type name when it is longer than 50 characters long.
    @estebank
    estebank committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    4ed1376 View commit details
    Browse the repository at this point in the history

  4. Only use ... instead of _ for type elision 

    `_` might confuse people into believing that the type isn't known,
while `...` is not used anywhere else for types and is not valid
syntax, making it more likely to convey the right understanding.
    @estebank
    estebank committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    3debf50 View commit details
    Browse the repository at this point in the history

  5. review comment

    @estebank
    estebank committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    bcb2655 View commit details
    Browse the repository at this point in the history