Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and harden various methods around trait substs #104533

Merged
merged 21 commits into from
Nov 22, 2022
Merged

Clean up and harden various methods around trait substs #104533

merged 21 commits into from
Nov 22, 2022

Commits on Nov 21, 2022

  1. Reduce the amount of passed-around arguments that will get merged int… 

    …o one later anyway
    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    0c47dee View commit details
    Browse the repository at this point in the history

  2. Check that type_implements_trait actually is passed the right amount … 

    …of generic params
    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    250dcf4 View commit details
    Browse the repository at this point in the history

  3. Use ty::List instead of InternalSubsts

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    48ff6a9 View commit details
    Browse the repository at this point in the history

  4. Split out the actual predicate solving code into a separate function

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    d9a02b0 View commit details
    Browse the repository at this point in the history

  5. Assert that various types have the right amount of generic args and f… 

    …ix the sites that used the wrong amount
    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    6f77c97 View commit details
    Browse the repository at this point in the history

  6. Add a helper for replacing the self type in trait refs

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    19a1192 View commit details
    Browse the repository at this point in the history

  7. Remove an unnecessary query + subst round

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    bd40c10 View commit details
    Browse the repository at this point in the history

  8. Allow iterators instead of requiring slices that will get turned into… 

    … iterators
    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    ec8d01f View commit details
    Browse the repository at this point in the history

  9. Use iterators instead of slices at more sites

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    9e4c3f4 View commit details
    Browse the repository at this point in the history

  10. Some cleanup around trait_method lookup

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    25c4760 View commit details
    Browse the repository at this point in the history

  11. Add helper to create the trait ref for a lang item

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    ad57f88 View commit details
    Browse the repository at this point in the history

  12. For lcnr

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    a9f3c22 View commit details
    Browse the repository at this point in the history

  13. Fix an ICE that I just made worse

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    4d9451b View commit details
    Browse the repository at this point in the history

  14. Remove a redundant assert

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    48ea298 View commit details
    Browse the repository at this point in the history

  15. Remove some unnecessary slicing

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    472444b View commit details
    Browse the repository at this point in the history

  16. Fix clippy's missing substs

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    a4da3f8 View commit details
    Browse the repository at this point in the history

  17. Stop passing the self-type as a separate argument.

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    7658e0f View commit details
    Browse the repository at this point in the history

  18. Use as_closure helper method 

    Co-authored-by: lcnr <rust@lcnr.de>
    @oli-obk @lcnr
    oli-obk and lcnr committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    24cdb72 View commit details
    Browse the repository at this point in the history

  19. Simplify test 

    Co-authored-by: lcnr <rust@lcnr.de>
    @oli-obk @lcnr
    oli-obk and lcnr committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    5316378 View commit details
    Browse the repository at this point in the history

  20. Simplify one more TraitRef::new site

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    a6c5212 View commit details
    Browse the repository at this point in the history

  21. merge self type and substs in trait_method

    @oli-obk
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    c2ecd8f View commit details
    Browse the repository at this point in the history