Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small method code cleanup #104890

Merged
merged 4 commits into from
Nov 28, 2022
Merged

small method code cleanup #104890

merged 4 commits into from
Nov 28, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Nov 25, 2022

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2022

r? @fee1-dead

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 25, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lcnr
remove TypeError::ObjectUnsafeCoercion
a215b7b
@lcnr
remove confusing comment
4f07008 
`?0: CoerceUnsized<SomeTy>` can definitely apply because
`?0` matches any type, same for `SomeTy: CoerceUnsized<?0>`
@lcnr @fee1-dead
fix type
99c3dda 
Co-authored-by: fee1-dead <ent3rm4n@gmail.com>
@fee1-dead
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 28, 2022

📌 Commit 99c3dda has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Nov 28, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2022
@bors
Auto merge of rust-lang#105008 - Dylan-DPC:rollup-wcd19yu, r=Dylan-DPC
8a09420 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#104360 (Stabilize native library modifier `verbatim`)
 - rust-lang#104732 (Refactor `ty::ClosureKind` related stuff)
 - rust-lang#104795 (Change multiline span ASCII art visual order)
 - rust-lang#104890 (small method code cleanup)
 - rust-lang#104907 (Remove `SelectionContext::infcx()` in favor of field access)
 - rust-lang#104927 (Simplify some binder shifting logic)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8a84dd8 into rust-lang:master Nov 28, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 28, 2022
@lcnr lcnr deleted the small-cleanup branch November 29, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fee1-dead fee1-dead fee1-dead left review comments

Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lcnr @rustbot @rust-log-analyzer @fee1-dead @bors