Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract llvm datalayout parsing out of spec module #105087

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Extract llvm datalayout parsing out of spec module #105087

merged 1 commit into from
Dec 1, 2022

Conversation

HKalbasi
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2022

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 30, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2022

These commits modify compiler targets.
(See the Target Tier Policy.)

eddyb
eddyb requested changes Nov 30, 2022
View reviewed changes
Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after moving the method up (and either adding a comment or doing the 4-field struct).

compiler/rustc_abi/src/lib.rs Show resolved Hide resolved
@petrochenkov
Copy link
Contributor

@bors r=eddyb

@bors
Copy link
Contributor

bors commented Nov 30, 2022

📌 Commit 56126fb has been approved by eddyb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2022
@petrochenkov
Copy link
Contributor

@bors rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 1, 2022
@matthiaskrgr
Rollup merge of rust-lang#105087 - HKalbasi:master, r=eddyb
a2e73d8 
Extract llvm datalayout parsing out of spec module

fix rust-lang#103693 (comment)
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 1, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Dec 1, 2022
@Dylan-DPC
Rollup merge of rust-lang#105087 - HKalbasi:master, r=eddyb
8bdae2e 
Extract llvm datalayout parsing out of spec module

fix rust-lang#103693 (comment)
@Dylan-DPC Dylan-DPC mentioned this pull request Dec 1, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 1, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2022
@bors
Auto merge of rust-lang#105125 - matthiaskrgr:rollup-fr0snmj, r=matth…
c090c68 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#105078 (Fix `expr_to_spanned_string` ICE)
 - rust-lang#105087 (Extract llvm datalayout parsing out of spec module)
 - rust-lang#105088 (rustdoc: remove redundant CSS `div.desc { display: block }`)
 - rust-lang#105106 (Fix ICE from rust-lang#105101)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit adec7ee into rust-lang:master Dec 1, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb requested changes

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@HKalbasi @rustbot @petrochenkov @bors @eddyb