use problem matchers for tidy CI #106085

fee1-dead · 2022-12-23T15:00:20Z

No description provided.

rustbot · 2022-12-23T15:00:26Z

(rustbot has picked a reviewer for you, use r? to override)

fee1-dead · 2022-12-24T15:36:08Z

See this to confirm that it is working correctly.

pietroalbini · 2022-12-24T20:39:56Z

The duplication is unfortunate... tidy should (?) be the same across jobs, can we collect annotations only from one of them?

fee1-dead · 2022-12-25T08:22:54Z

The duplication is unfortunate... tidy should (?) be the same across jobs, can we collect annotations only from one of them?

It might be best to only run tidy on mingw-check-tidy. A lot of other platforms run by bors run full tests which include tidy already so that should not be a concern for bors. For PR CI the mingw-check-tidy job was designed to not cancel other (perhaps with more interesting errors) jobs if tidy fails.

Mark-Simulacrum · 2022-12-25T12:09:26Z

I believe some parts of tidy are platform specific (e.g., checking binaries/executable files checked into tree). I'm not sure if there's anything else like that.

fee1-dead · 2022-12-26T15:24:58Z

I believe some parts of tidy are platform specific (e.g., checking binaries/executable files checked into tree). I'm not sure if there's anything else like that.

I checked that part of tidy and it looks like it only runs on unix systems and it just checks if there are files marked as executable.

pietroalbini · 2023-01-05T11:46:43Z

Yeah let's only run tidy in its dedicated job to remove the duplicate annotations.

fee1-dead · 2023-01-06T15:33:25Z

I've pushed a commit to not run tidy on x86_64-gnu-llvm-13, which should resolve this.

fee1-dead · 2023-02-25T10:14:05Z

@pietroalbini @Mark-Simulacrum any updates?

pietroalbini · 2023-03-05T18:07:49Z

@bors r+

bors · 2023-03-05T18:07:51Z

📌 Commit ab8b63f3abfaaee85ba5d928b56c0eb4541ef4fb has been approved by pietroalbini

It is now in the queue for this repository.

bors · 2023-03-06T04:30:41Z

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout tidy-ci-matchers (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self tidy-ci-matchers --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

CONFLICT (modify/delete): src/ci/docker/host-x86_64/x86_64-gnu-llvm-13/Dockerfile deleted in HEAD and modified in heads/homu-tmp. Version heads/homu-tmp of src/ci/docker/host-x86_64/x86_64-gnu-llvm-13/Dockerfile left in tree.
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 27502 and retry the command.
Automatic merge failed; fix conflicts and then commit the result.

fee1-dead · 2023-03-07T12:53:09Z

Rebased.

@bors r=pietroalbini

bors · 2023-03-07T12:53:11Z

📌 Commit a2040de has been approved by pietroalbini

It is now in the queue for this repository.

…, r=pietroalbini use problem matchers for tidy CI

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#105798 (Relax ordering rules for `asm!` operands) - rust-lang#105962 (Stabilize path_as_mut_os_str) - rust-lang#106085 (use problem matchers for tidy CI) - rust-lang#107711 (Stabilize movbe target feature) - rust-lang#108017 (Add `--no-undefined-version` link flag and fix associated breakage) - rust-lang#108891 (Remove an extraneous include) - rust-lang#108902 (no more do while :<) - rust-lang#108912 (Document tool lints) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

This also fixes a regression from rust-lang#106085 which stopped testing that we support python2 in PR CI.

…lacrum Add tests for configure.py I highly recommend reviewing this with whitespace disabled. Notably, verifying that we generate valid toml relies on python 3.11 so we can use `tomllib`, so this also switches`x86_64-gnu-llvm-14` (one of the PR builders) to use 3.11. While fixing that, I noticed that we stopped testing python2.7 support on PR CI in rust-lang#106085. `@fee1-dead` `@pietroalbini` please be more careful in the future, there is no CI for CI itself that verifies we are testing everything we should be. - Separate out functions so that each unit test doesn't create a file on disk - Add a few unit tests

Like rust-lang#107044, this will let us track compatibility with LLVM 16 going forward, especially after we eventually upgrade our own to the next. This also drops `tidy` here and in `x86_64-gnu-llvm-15`, syncing with that change in rust-lang#106085.

…lacrum ci: add a runner for vanilla LLVM 16 Like rust-lang#107044, this will let us track compatibility with LLVM 16 going forward, especially after we eventually upgrade our own to the next. This also drops `tidy` here and in `x86_64-gnu-llvm-15`, syncing with that change in rust-lang#106085.

rustbot assigned pietroalbini Dec 23, 2022

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 23, 2022

fee1-dead force-pushed the tidy-ci-matchers branch from e0edc43 to 88889c1 Compare December 23, 2022 15:06

This comment has been minimized.

Sign in to view

fee1-dead force-pushed the tidy-ci-matchers branch 2 times, most recently from 77424db to 7e29713 Compare December 24, 2022 14:09

fee1-dead marked this pull request as ready for review December 24, 2022 15:34

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2023

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 6, 2023

fee1-dead added 2 commits March 6, 2023 07:13

use problem matchers for tidy CI

ef807cb

do not run tidy on x86_64-gnu-llvm-13

a2040de

fee1-dead force-pushed the tidy-ci-matchers branch from ab8b63f to a2040de Compare March 6, 2023 07:15

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2023

Rollup merge of rust-lang#106085 - fee1-dead-contrib:tidy-ci-matchers…

2904eb2

…, r=pietroalbini use problem matchers for tidy CI

matthiaskrgr mentioned this pull request Mar 10, 2023

Rollup of 9 pull requests #108968

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2023

Rollup merge of rust-lang#106085 - fee1-dead-contrib:tidy-ci-matchers…

e49100e

…, r=pietroalbini use problem matchers for tidy CI

matthiaskrgr mentioned this pull request Mar 10, 2023

Rollup of 10 pull requests #108982

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2023

Rollup merge of rust-lang#106085 - fee1-dead-contrib:tidy-ci-matchers…

eed1d0c

…, r=pietroalbini use problem matchers for tidy CI

matthiaskrgr mentioned this pull request Mar 10, 2023

Rollup of 9 pull requests #108989

Closed

matthiaskrgr mentioned this pull request Mar 10, 2023

Rollup of 8 pull requests #109001

Merged

bors merged commit b5de008 into rust-lang:master Mar 11, 2023

rustbot added this to the 1.70.0 milestone Mar 11, 2023

jyn514 mentioned this pull request Mar 17, 2023

Add tests for configure.py #109267

Merged

jyn514 added a commit to jyn514/rust that referenced this pull request Mar 17, 2023

Use python3.11 in CI to make sure toml is validated

c7eccda

This also fixes a regression from rust-lang#106085 which stopped testing that we support python2 in PR CI.

jyn514 mentioned this pull request Mar 17, 2023

Mock environment testing for bootstrap #102563

Open

oli-obk deleted the tidy-ci-matchers branch March 31, 2023 11:42

cuviper mentioned this pull request Apr 12, 2023

ci: add a runner for vanilla LLVM 16 #110242

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use problem matchers for tidy CI #106085

use problem matchers for tidy CI #106085

fee1-dead commented Dec 23, 2022

rustbot commented Dec 23, 2022

This comment has been minimized.

fee1-dead commented Dec 24, 2022

pietroalbini commented Dec 24, 2022

fee1-dead commented Dec 25, 2022 •

edited

Loading

Mark-Simulacrum commented Dec 25, 2022

fee1-dead commented Dec 26, 2022

pietroalbini commented Jan 5, 2023

fee1-dead commented Jan 6, 2023

fee1-dead commented Feb 25, 2023

pietroalbini commented Mar 5, 2023

bors commented Mar 5, 2023

bors commented Mar 6, 2023

fee1-dead commented Mar 7, 2023

bors commented Mar 7, 2023

use problem matchers for tidy CI #106085

use problem matchers for tidy CI #106085

Conversation

fee1-dead commented Dec 23, 2022

rustbot commented Dec 23, 2022

This comment has been minimized.

fee1-dead commented Dec 24, 2022

pietroalbini commented Dec 24, 2022

fee1-dead commented Dec 25, 2022 • edited Loading

Mark-Simulacrum commented Dec 25, 2022

fee1-dead commented Dec 26, 2022

pietroalbini commented Jan 5, 2023

fee1-dead commented Jan 6, 2023

fee1-dead commented Feb 25, 2023

pietroalbini commented Mar 5, 2023

bors commented Mar 5, 2023

bors commented Mar 6, 2023

fee1-dead commented Mar 7, 2023

bors commented Mar 7, 2023

fee1-dead commented Dec 25, 2022 •

edited

Loading