Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stage2 rustdoc and proc-macro-srv disableable in x.py install #106886

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Jan 14, 2023

Rustdoc will build if [build] tools = ["rustdoc"] is set, and rust-analyzer-proc-macro-srv will build if [build] tools = ["rust-analyzer"] is set.

On my machine skipping these tools speeds up x.py install from 7m15s to 6m08s (0m43s for rustdoc and 0m24s for rust-analyzer-proc-macro-srv). This is a significant speedup, since I never use rust-analyzer-proc-macro-srv, and I practically never need to use a custom build of rustdoc.

@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2023

📌 Commit 11e002a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2023
Rollup of 7 pull requests

Successful merges:

 - rust-lang#106796 (BPF: Disable atomic CAS)
 - rust-lang#106886 (Make stage2 rustdoc and proc-macro-srv disableable in x.py install)
 - rust-lang#107101 (Filter param-env predicates for errors before calling `to_opt_poly_trait_pred`)
 - rust-lang#107109 (ThinBox: Add intra-doc-links for Metadata)
 - rust-lang#107148 (remove error code from `E0789`, add UI test/docs)
 - rust-lang#107151 (Instantiate dominators algorithm only once)
 - rust-lang#107153 (Consistently use dominates instead of is_dominated_by)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ae15d10 into rust-lang:master Jan 23, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 23, 2023
@dtolnay dtolnay deleted the fastinstall branch January 31, 2023 19:45
@jonhoo
Copy link
Contributor

jonhoo commented Apr 21, 2023

Just to leave a breadcrumb for anyone running into this down the line: the way you (may) run into this if you build your own Rust from source and previously specified --tools without including rustdoc in the list is:

     Running unittests src/lib.rs (build/private/cargo-target/debug/deps/amzn_test-9420f7791d82af57)
   Doc-tests amzn-test
error: doctest failed, to rerun pass `--doc`

Caused by:
  could not execute process `rustdoc --edition=2021 ... --error-format human` (never executed)

Caused by:
  No such file or directory (os error 2) 

The fix is to add rustdoc to the tools list in config.toml.

@jonhoo
Copy link
Contributor

jonhoo commented Apr 21, 2023

It may(?) be worth adding this to the "Compatibility Notes" section in the Rust changelog. Took me a while to trace the issue back to this PR.

@Mark-Simulacrum Mark-Simulacrum added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 21, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 22, 2023
…=cuviper

Add note about change in bootstrap defaults

Not a huge fan of the proposed wording, open to changes in that.

Per rust-lang#106886 (comment).
cc `@jonhoo`

r? `@cuviper` perhaps?
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 23, 2023
…=cuviper

Add note about change in bootstrap defaults

Not a huge fan of the proposed wording, open to changes in that.

Per rust-lang#106886 (comment).
cc `@jonhoo`

r? `@cuviper` perhaps?
@jhheider jhheider mentioned this pull request Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants