Extend BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE.
#107713
Conversation
rustbot
added
S-waiting-on-review
|
Thanks! |
|
📌 Commit f075d484589c0f53a474b0afd676c29c66c150d6 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
| // be removable relatively quickly, because there are | ||
| // no known crates for which they make the difference | ||
| // between "the crate compiles" and "the crate does not | ||
| // compile". |
There was a problem hiding this comment.
This can't be entirely true, can it? The compiler depends on icu4x and that was still building even before unicode-org/icu4x#3060 got fixed. The [u8] hack and unicode-org/icu4x#2834 were sufficient for that (in fact either one should be sufficient). Looks like only some configurations of icu4x are affected by unicode-org/icu4x#3060, and some other configurations are helped by this hack?
Cc @Manishearth
There was a problem hiding this comment.
ICU4X is many components, the compiler only uses one of them, which doesn't do extremely fancy zero-copy stuff (it only does normal zero-copy stuff).
There was a problem hiding this comment.
Okay, so there are cases where these hacks actually help the build to succeed.
@nnethercote can you adjust the comment? Then r=me.
There was a problem hiding this comment.
Thanks for the clarification. That makes me feel better about the whole lint :)
There was a problem hiding this comment.
Yeah, some cases, though in some cases the last field is a ZeroSlice or something, so I don't think a full ICU4X build is fixed by this. However like I said we have a dep update that fixes this so it's not a huge deal.
|
@bors r- |
bors
added
S-waiting-on-author
To temporarily allow a `str` field in a packed struct using `derive`, along with `[u8]`.
nnethercote
force-pushed
the
extend-BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE
branch
from
f075d48
to
a70d03b
Compare
|
I removed the erroneous comment. @bors r=RalfJung |
bors
added
S-waiting-on-bors
…ACKED_STRUCT_WITH_DERIVE, r=RalfJung Extend `BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE`. To temporarily allow a `str` field in a packed struct using `derive`, along with `[u8]`. r? `@RalfJung`
…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#107317 (Implement `AsFd` and `AsRawFd` for `Rc`) - rust-lang#107429 (Stabilize feature `cstr_from_bytes_until_nul`) - rust-lang#107713 (Extend `BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE`.) - rust-lang#107761 (Replace a command line flag with an env var to allow tools to initialize the tracing loggers at their own discretion) - rust-lang#107790 ( x.py fails all downloads that use a tempdir with snap curl rust-lang#107722) - rust-lang#107799 (correctly update goals in the cache) - rust-lang#107813 (Do not eagerly recover for bad `impl Trait` types in macros) - rust-lang#107817 (rustdoc: use svgo to shrink `wheel.svg`) - rust-lang#107819 (Set `rust-analyzer.check.invocationLocation` to `root`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
To temporarily allow a
strfield in a packed struct usingderive, along with[u8].r? @RalfJung