Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lexer): print whitespace warning for \x0c #108900

Merged
merged 1 commit into from
Mar 11, 2023
Merged

fix(lexer): print whitespace warning for \x0c #108900

merged 1 commit into from
Mar 11, 2023

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Mar 8, 2023

@rustbot
Copy link
Collaborator

rustbot commented Mar 8, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 8, 2023
@bvanjoi bvanjoi changed the title fix(lexer): not print warning during skip ascii whitespace for \x0c fix(lexer): print whitespace warni for \x0c Mar 8, 2023
@bvanjoi bvanjoi force-pushed the issue-108275 branch 2 times, most recently from eb720fa to 61f5396 Compare March 8, 2023 14:17
@bvanjoi bvanjoi changed the title fix(lexer): print whitespace warni for \x0c fix(lexer): print whitespace warning for \x0c Mar 8, 2023
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2023
@bvanjoi
Copy link
Contributor Author

bvanjoi commented Mar 9, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2023
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2023
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 9, 2023

📌 Commit d223c26 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 11, 2023
@bors
Auto merge of rust-lang#108998 - matthiaskrgr:rollup-sxbdulg, r=matth…
19c5376 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#106921 (Add documentation about the memory layout of `Cell`)
 - rust-lang#108828 (Emit alias-eq when equating numeric var and projection)
 - rust-lang#108834 (Do not ICE when we have fn pointer `Fn` obligations with bound vars in the self type)
 - rust-lang#108900 (fix(lexer): print whitespace warning for \x0c)
 - rust-lang#108930 (feat: implement better error for manual impl of `Fn*` traits)
 - rust-lang#108937 (improve readability of winnowing)
 - rust-lang#108947 (Don't even try to combine consts with incompatible types)
 - rust-lang#108976 (Update triagebot rust-analyzer team mention)
 - rust-lang#108983 (Forbid `#[target_feature]` on safe default implementations)

Failed merges:

 - rust-lang#108950 (Directly construct Inherited in typeck.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4ad3230 into rust-lang:master Mar 11, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 11, 2023
@bvanjoi bvanjoi deleted the issue-108275 branch April 3, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

string continue non-ASCII whitespace confusing as \x0C is ASCII whitespace
4 participants
@bvanjoi @rustbot @petrochenkov @bors