Group some sections of our logs in github actions #110637
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jyn514 (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
|
Here's how it looks on my phone:
|
There was a problem hiding this comment.
This is really awesome! I didn't realize this was even possible. I think it's going to make #97338 a lot easier too 😍 doing this as a function on builder instead of part of the Step was a good idea, reduces boilerplate.
I want to go over the CI logs and make sure there's no regressions (I think I saw a few extra spaces which are NBD but would be nice to fix), but I'm out of time for today - hopefully this is useful in the meantime.
|
@bors r=jyn514 rollup |
bors
added
S-waiting-on-bors
Group some sections of our logs in github actions This makes logs a little bit more readable as you can now collapse all the parts that don't interest you (and they get collapsed automatically) Obviously there's a lot more sites where we can/need to do this, too, but this is already helpful imo r? ``@jyn514``
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#110255 (Suggest using integration tests for test crate using own proc-macro) - rust-lang#110514 (Remove `find_map_relevant_impl`) - rust-lang#110566 (Don't create projection ty for const projection) - rust-lang#110637 (Group some sections of our logs in github actions) - rust-lang#110706 (Add `intrinsics::transmute_unchecked`) - rust-lang#110714 (Normalize types and consts in MIR opts.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This makes logs a little bit more readable as you can now collapse all the parts that don't interest you (and they get collapsed automatically)
Obviously there's a lot more sites where we can/need to do this, too, but this is already helpful imo
r? @jyn514