Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experiment] Relax tuple comparison impls #112899

Conversation

compiler-errors
Copy link
Member

Two should be able to be compared element-wise even if the tuples aren't exactly the same type

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 21, 2023
@compiler-errors
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jun 21, 2023

⌛ Trying commit 0bc5699 with merge 4ced648d00a007b83b95f4efef26c0199fb5b435...

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    Checking syn v2.0.8
error[E0282]: type annotations needed
   --> compiler/rustc_interface/src/tests.rs:641:57
    |
641 |     tracked!(remap_path_prefix, vec![("/home/bors/rust".into(), "src".into())]);
    |
help: try using a fully qualified path to specify the expected types
    |
    |
641 |     tracked!(remap_path_prefix, vec![(<&str as Into<T>>::into("/home/bors/rust"), "src".into())]);

    Checking rustc_passes v0.0.0 (/checkout/compiler/rustc_passes)
    Checking rustc_expand v0.0.0 (/checkout/compiler/rustc_expand)
For more information about this error, try `rustc --explain E0282`.

@bors
Copy link
Contributor

bors commented Jun 21, 2023

☀️ Try build successful - checks-actions
Build commit: 4ced648d00a007b83b95f4efef26c0199fb5b435 (4ced648d00a007b83b95f4efef26c0199fb5b435)

@compiler-errors
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-112899 created and queued.
🤖 Automatically detected try build 4ced648d00a007b83b95f4efef26c0199fb5b435
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-112899 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-112899 is completed!
📊 683 regressed and 5 fixed (304944 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 25, 2023
@compiler-errors
Copy link
Member Author

Oof, quite a few crates rely on the old inference behavior. How sad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants