Fix display of long items in search results #113100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
search-result-long-name
branch
from
3fc9f77
to
c3eda45
Compare
|
Please make mobile view not do the alignment? It looks weird when it's not a table:
|
|
Good point. |
camelid
reviewed
Jun 27, 2023
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| :root { | |||
| --nav-sub-mobile-padding: 8px; | |||
| --search-typename-width: 6.75rem; | |||
There was a problem hiding this comment.
Did you intentionally increase this from 6.25rem to 6.75rem?
There was a problem hiding this comment.
Yes because the whitespace is not displayed anymore because of display: flex. The rendering is the same though.
GuillaumeGomez
force-pushed
the
search-result-long-name
branch
from
c3eda45
to
9adbe63
Compare
|
Fix what @notriddle mentioned and updated online demo. |
|
That still looks weird. Can you make it so that, on mobile, it lays it out like it did before, treating the type name as just part of the text?
|
GuillaumeGomez
force-pushed
the
search-result-long-name
branch
from
9adbe63
to
00cf60a
Compare
|
Good catch! I fixed that, updated the demo and added a GUI test. |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
search-result-long-name
branch
from
00cf60a
to
a716c79
Compare
|
Fixed tidy. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2023
Rollup of 5 pull requests Successful merges: - rust-lang#112946 (Improve cgu naming and ordering) - rust-lang#113048 (Fix build on Solaris where fd-lock cannot be used.) - rust-lang#113100 (Fix display of long items in search results) - rust-lang#113107 (add check for ConstKind::Value(_) to in_operand()) - rust-lang#113119 (rustdoc: Reduce internal function visibility.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113060.
You can test the result here.
To make it a bit better, I also reduced a bit the size of the short documentation from half to 2 fifth of the width.
r? @notriddle