style-guide: Clarify let-else further #113139
Conversation
Give some additional examples with multi-line patterns. Make it clearer to go on to the next case if the conditions aren't met.
|
r? @yaahc (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/doc/style-guide cc @rust-lang/style |
| If the initializer expression is multi-line, the `else` keyword and opening | ||
| brace of the block (i.e. `else {`) should be put on the same line as the end of | ||
| the initializer expression, with a space between them, if all the following are | ||
| true: | ||
| the initializer expression, with a space between them, if and only if all the | ||
| following are true: |
There was a problem hiding this comment.
I feel like the ambiguity comes from the fact that this all starts with the "if the initializer expression is multi-line" up on line 160, as that could be read as meaning the text that follows is not applicable if the expr itself is single line.
I'll think on some additional text proposals, but wanted to go ahead and share that.
There was a problem hiding this comment.
That's true, but in the single-line case it doesn't matter if you try to apply these rules or not; the three conditions can't possibly hold for a single-line initializer. You can't have a single-line initializer expression that consists of nothing but closing parentheses, square brackets, and/or braces.
So, whether you look at this case and go "doesn't apply because it's not multi-line" or look at this case and go "doesn't apply because the conditions don't hold", either way you go on to the next case.
|
@bors r=calebcartwright rollup Going to go ahead and merge this with Caleb's r+; we can still make further text improvements as they arise. |
bors
added
S-waiting-on-bors
joshtriplett
changed the title
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112670 (privacy: Type privacy lints fixes and cleanups) - rust-lang#112929 (Test that we require implementing trait items whose bounds don't hold in the current impl) - rust-lang#113054 (Make `rustc_on_unimplemented` std-agnostic) - rust-lang#113137 (don't suggest `move` for borrows that aren't closures) - rust-lang#113139 (style-guide: Clarify let-else further) - rust-lang#113140 (style-guide: Add an example of formatting a multi-line attribute) - rust-lang#113143 (style-guide: Narrow guidance about references and dereferencing) r? `@ghost` `@rustbot` modify labels: rollup
Give some additional examples with multi-line patterns.
Make it clearer to go on to the next case if the conditions aren't met.