Rollup of 7 pull requests

[matthiaskrgr]

Successful merges:

• impl SliceIndex<str> for (Bound<usize>, Bound<usize>) #111081 (impl SliceIndex for (Bound, Bound))
• style-guide: Document style editions, start 2024 style edition #113394 (style-guide: Document style editions, start 2024 style edition)
• bootstrap: use git merge-base for LLVM CI download logic #113588 (bootstrap: use git merge-base for LLVM CI download logic)
• Directly link more target docs #113743 (Directly link more target docs)
• Improve the rust style guide doc #114262 (Improve the rust style guide doc)
• Update books #114309 (Update books)
• [rustc_data_structures] Simplify SortedMap::insert. #114313 ([rustc_data_structures] Simplify SortedMap::insert.)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=7

[bors]

📌 Commit a902550 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit a902550 with merge 91a41abd6ac0a95b49cd69d488feed224279d5c2...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 91a41abd6ac0a95b49cd69d488feed224279d5c2 to master...

[bors]

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

[matthiaskrgr]

@bors retry

[bors]

⌛ Testing commit a902550 with merge c435af0...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing c435af0 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#111081	impl SliceIndex for (Bound, Bound)	efafddd828be3291dfd77e0fd26206347f67535b (link)
#113394	style-guide: Document style editions, start 2024 style edit…	434a16f9fea0be05baaab05db639d2c69a41ad27 (link)
#113588	bootstrap: use git merge-base for LLVM CI download logic	8c75635a1aa05c03a1a540379ab66ce477a21489 (link)
#113743	Directly link more target docs	9157d50e741b8dac5148c0eda3aeb0ce7194a927 (link)
#114262	Improve the rust style guide doc	39fccfc1cf7d82f01327996915d02ddee0f0c18c (link)
#114309	Update books	1e582a39d4190899fac2630dc38912260ed4074b (link)
#114313	[rustc_data_structures] Simplify SortedMap::insert.	68daa9d1d17eaa24bc223f7be124b04a825fa9e2 (link)

previous master: 866710c552

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (91a41abd6ac0a95b49cd69d488feed224279d5c2): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Warning ⚠: The following benchmark(s) failed to build:

• rustc

cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.1%	[6.1%, 6.1%]	1
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-3.2%, -2.0%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.1%	[-1.1%, -1.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data

[rust-timer]

Finished benchmarking commit (c435af0): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Warning ⚠: The following benchmark(s) failed to build:

• rustc

cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.3%, -0.2%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-0.3%, -0.2%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.3%	[3.8%, 4.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.5%	[4.7%, 6.2%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data

[Kobzol]

This PR was somehow merged twice (and thus perf. tested twice). I'm not sure if the rustc build regression is caused by that or if it's something else (maybe #113588 or #114309, since these dealt with git somehow?)

[lqd]

91a41abd6ac0a95b49cd69d488feed224279d5c2 doesn't look to be on master compared to c435af0, probably thanks to the failed fast forward, however webhooks may have been sent to the perf server anyways?

The rustc error is weird, it mentions e62323d but it's an old commit. Maybe because it was testing a "regular merge commit" that was not actually on master, the usual git commands or #113588 didn't work 🤔

We can see if it fixes itself in the next couple merged PR it profiles, and otherwise see what needs to be done to update that benchmark (or revert the PR 👼)