Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump backtrace to 0.3.69 #115112

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Bump backtrace to 0.3.69 #115112

merged 1 commit into from
Aug 23, 2023

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Aug 22, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2023
@compiler-errors
Copy link
Member

nice

@bors r+

@bors
Copy link
Contributor

bors commented Aug 22, 2023

📌 Commit aec835ab5f245bf5d804258ba9e7d268a99a13a0 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2023
@klensy
Copy link
Contributor

klensy commented Aug 22, 2023

Maybe bump dependency too?

@compiler-errors
Copy link
Member

Right, probably should bump the Cargo.lock too I guess.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@tmandry
Copy link
Member Author

tmandry commented Aug 22, 2023

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Aug 22, 2023

📌 Commit 4c14ca3 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 23, 2023
@bors
Copy link
Contributor

bors commented Aug 23, 2023

⌛ Testing commit 4c14ca3 with merge 249595b...

@bors
Copy link
Contributor

bors commented Aug 23, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 249595b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 23, 2023
@bors bors merged commit 249595b into rust-lang:master Aug 23, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 23, 2023
@tmandry tmandry deleted the backtrace-0369 branch August 23, 2023 21:33
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (249595b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.3% [3.3%, 3.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 635.332s -> 635.214s (-0.02%)
Artifact size: 347.24 MiB -> 347.18 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants