Add note to is_known_rigid
#116041
Merged
Add note to is_known_rigid
#116041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
rust-cloud-vms
bot
force-pushed
the
rigid-note
branch
from
3f35ab3
to
e63b41f
Compare
RalfJung
reviewed
Sep 21, 2023
compiler/rustc_middle/src/ty/sty.rs
Outdated
| @@ -2946,6 +2946,11 @@ impl<'tcx> Ty<'tcx> { | |||
| } | |||
| } | |||
|
|
|||
| /// Whether the outermost type cannot be further normalized, resolved, or | |||
There was a problem hiding this comment.
Suggested change
| /// Whether the outermost type cannot be further normalized, resolved, or | |
| /// Returns `true` when the outermost type cannot be further normalized, resolved, or |
|
r=me with comment nit fixed |
rust-cloud-vms
bot
force-pushed
the
rigid-note
branch
from
e63b41f
to
7fc081b
Compare
|
@bors r=RalfJung |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#114379 (Command: also print removed env vars) - rust-lang#116034 (add UI test for delimiter errors) - rust-lang#116036 (tests/ui: Split large_moves.rs and move to lint/large_assignments) - rust-lang#116038 (Fall back to _SC_NPROCESSORS_ONLN if sched_getaffinity returns an empty mask) - rust-lang#116039 (Account for nested `impl Trait` in TAIT) - rust-lang#116041 (Add note to `is_known_rigid`) - rust-lang#116049 (give FutureIncompatibilityReason variants more explicit names) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
Rollup merge of rust-lang#116041 - compiler-errors:rigid-note, r=RalfJung Add note to `is_known_rigid` Adds a note requested by `@RalfJung` in rust-lang#114941 (comment) Let me know if there are any other fns that need documentation, I could throw them into this PR too :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a note requested by @RalfJung in #114941 (comment)
Let me know if there are any other fns that need documentation, I could throw them into this PR too :)