Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for rust-lang#114912 #116256

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Add test for rust-lang#114912 #116256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/ui/async-await/debug-ice-attempted-to-add-with-overflow.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// check-fail
// edition:2021

// test for issue-114912 - debug ice: attempted to add with overflow

async fn main() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async fn main() {
fn main() {

We do not support async main so we can remote it? of there is any reason that I am missing to add it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just following the issue, which I presume wanted to be tested for with the async/await if not the await itself would have to removed too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, ok it is fine for me.

another way to write the same thing is

fn main() {
   let _ = async { 
      [0usize; 0xffff_ffff_ffff_ffff].await;
   };
}

In this way, you have no longer the problem of the async fn main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you prefer it this way, or okay with how it is now? Thanks for the tip :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you prefer it this way, or okay with how it is now? Thanks for the tip :)

for me, it is fine either way, with the second way you avoid just to generate a second error

error[E0752]: main function is not allowed to be async

but maybe a t-compiler member will have some preference, for me there is no problem :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks mate.

//~^ ERROR `main` function is not allowed to be `async`
[0usize; 0xffff_ffff_ffff_ffff].await;
//~^ ERROR `[usize; usize::MAX]` is not a future
}
23 changes: 23 additions & 0 deletions tests/ui/async-await/debug-ice-attempted-to-add-with-overflow.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
error[E0277]: `[usize; usize::MAX]` is not a future
--> $DIR/debug-ice-attempted-to-add-with-overflow.rs:8:37
|
LL | [0usize; 0xffff_ffff_ffff_ffff].await;
| -^^^^^
| ||
| |`[usize; usize::MAX]` is not a future
| help: remove the `.await`
|
= help: the trait `Future` is not implemented for `[usize; usize::MAX]`
= note: [usize; usize::MAX] must be a future or must implement `IntoFuture` to be awaited
= note: required for `[usize; usize::MAX]` to implement `IntoFuture`

error[E0752]: `main` function is not allowed to be `async`
--> $DIR/debug-ice-attempted-to-add-with-overflow.rs:6:1
|
LL | async fn main() {
| ^^^^^^^^^^^^^^^ `main` function is not allowed to be `async`

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0277, E0752.
For more information about an error, try `rustc --explain E0277`.
Loading