Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #116346

Merged
merged 9 commits into from
Oct 2, 2023
Merged

Rollup of 3 pull requests #116346

merged 9 commits into from
Oct 2, 2023

Commits on Oct 1, 2023

  1. Minor comment and whitespace tweaks.

    @nnethercote
    nnethercote committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    86ecfdd View commit details
    Browse the repository at this point in the history

  2. Rename two parsing closures. 

    To match `parse_address_space` and `parse_bits` above.
    @nnethercote
    nnethercote committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    ddb7422 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary pubs.

    @nnethercote
    nnethercote committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    2369adc View commit details
    Browse the repository at this point in the history

  4. Name some local variables more consistently. 

    By making every `alt_foo` exactly match a `foo`.
    @nnethercote
    nnethercote committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    17e3793 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Correct misleading std::fmt::Binary example

    @Colonial-Dev
    Colonial-Dev committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    f2ecf7c View commit details
    Browse the repository at this point in the history

  2. skip_binder to instantiate_identity

    @lcnr
    lcnr committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    dbc2cc8 View commit details
    Browse the repository at this point in the history

  3. Rollup merge of rust-lang#116313 - nnethercote:rustc_abi, r=the8472 

    Some small cleanups in `rustc_abi`

Minor things I found while looking at this crate's code.

r? `@the8472`
    @matthiaskrgr
    matthiaskrgr committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    e51a2aa View commit details
    Browse the repository at this point in the history

  4. Rollup merge of rust-lang#116326 - Colonial-Dev:issue-116165-fix, r=j… 

    …oshtriplett

Correct misleading std::fmt::Binary example (rust-lang#116165)

Nothing too crazy...

- Add two to the width specifier (so all 32 bits are correctly displayed)
- Pad out the compared string so the assert passes
- Add `// Note` comment highlighting the need for the extra width when using the `#` flag.

The exact contents (and placement?) of the note are, of course, highly bikesheddable.
    @matthiaskrgr
    matthiaskrgr committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    b3853cc View commit details
    Browse the repository at this point in the history

  5. Rollup merge of rust-lang#116340 - lcnr:early-binder-skip_binder, r=c… 

    …ompiler-errors

`skip_binder` to `instantiate_identity`
    @matthiaskrgr
    matthiaskrgr committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    cfe9e13 View commit details
    Browse the repository at this point in the history