Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #117482

Merged
merged 8 commits into from
Nov 1, 2023
Merged

Rollup of 4 pull requests #117482

merged 8 commits into from
Nov 1, 2023

Commits on Oct 13, 2023

  1. Configuration menu
    Copy the full SHA
    91405ab View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Configuration menu
    Copy the full SHA
    8076414 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    147c4a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Inline and remove create_session.

    Currently the parts of session initialization that happen within
    `rustc_interface` are split between `run_compiler` and `create_session`.
    This split isn't necessary and obscures what's happening.
    
    This commit merges the two functions. I think a single longer function
    is much clearer than splitting this code across two functions in
    different modules, especially when `create_session` has 13 parameters,
    and is misnamed (it also creates the codegen backend). The net result is
    43 fewer lines of code.
    nnethercote committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    587af91 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#115626 - clarfonthey:unchecked-math, r=thomcc

    Clean up unchecked_math, separate out unchecked_shifts
    
    Tracking issue: rust-lang#85122
    
    Changes:
    
    1. Remove `const_inherent_unchecked_arith` flag and make const-stability flags the same as the method feature flags. Given the number of other unsafe const fns already stabilised, it makes sense to just stabilise these in const context when they're stabilised.
    2. Move `unchecked_shl` and `unchecked_shr` into a separate `unchecked_shifts` flag, since the semantics for them are unclear and they'll likely be stabilised separately as a result.
    3. Add an `unchecked_neg` method exclusively to signed integers, under the `unchecked_neg` flag. This is because it's a new API and probably needs some time to marinate before it's stabilised, and while it *would* make sense to have a similar version for unsigned integers since `checked_neg` also exists for those there is absolutely no case where that would be a good idea, IMQHO.
    
    The longer-term goal here is to prepare the `unchecked_math` methods for an FCP and stabilisation since they've existed for a while, their semantics are clear, and people seem in favour of stabilising them.
    matthiaskrgr committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    260e07b View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#117397 - compiler-errors:dont-emit-good-pat…

    …h-on-panic, r=TaKO8Ki
    
    Don't emit delayed good-path bugs on panic
    
    This should fix rust-lang#117381, cc ``@RalfJung``
    
    As opposed to delayed bugs, delayed *good path* bugs really don't make sense to show on panics.
    matthiaskrgr committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    6bbe22c View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#117401 - chenyukang:yukang-cleanup-hir-type…

    …ck-suggestions, r=compiler-errors
    
    Refactor: move suggestion functions from demand to suggestions
    
    follow-up from
    rust-lang#116841 (comment)
    matthiaskrgr committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    6c893e6 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#117475 - nnethercote:rm-create_session, r=o…

    …li-obk
    
    Inline and remove `create_session`.
    
    Currently the parts of session initialization that happen within `rustc_interface` are split between `run_compiler` and `create_session`. This split isn't necessary and obscures what's happening.
    
    This commit merges the two functions. I think a single longer function is much clearer than splitting this code across two functions in different modules, especially when `create_session` has 13 parameters, and is misnamed (it also creates the codegen backend). The net result is 43 fewer lines of code.
    
    r? ``@oli-obk``
    matthiaskrgr committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    515fdbf View commit details
    Browse the repository at this point in the history