Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #120807

Merged
merged 20 commits into from
Feb 8, 2024
Merged

Rollup of 9 pull requests #120807

merged 20 commits into from
Feb 8, 2024

Commits on Feb 2, 2024

  1. Configuration menu
    Copy the full SHA
    6b2a824 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Configuration menu
    Copy the full SHA
    cd21b1d View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. make future diffs minimal

    tshepang committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    0ce71f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f676c3d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    30793ca View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4733b1b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    da4ec6f View commit details
    Browse the repository at this point in the history
  6. Fix span_bug! backtraces

    oli-obk committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    6af2d3c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7dc182d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5cb9e31 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ad511ef View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#120590 - compiler-errors:dead, r=Nilstrieb

    Remove unused args from functions
    
    `#[instrument]` suppresses the unused arguments from a function, *and* suppresses unused methods too! This PR removes things which are only used via `#[instrument]` calls, and fixes some other errors (privacy?) that I will comment inline.
    
    It's possible that some of these arguments were being passed in for the purposes of being instrumented, but I am unconvinced by most of them.
    matthiaskrgr committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    4ffb1a7 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#120750 - compiler-errors:itctx-by-val, r=cj…

    …gillot
    
    No need to take `ImplTraitContext` by ref
    
    We used to mutate `ImplTraitContext`, so it used to be `&mut` mutable ref. Then I think it used to have non-`Copy` data in it, so we took it by `&` ref. Now, none of that remains, so just copy it around.
    matthiaskrgr committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    1f31daa View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#120769 - tshepang:minimal-diffs, r=wesleywiser

    make future diffs minimal
    matthiaskrgr committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    2386c7c View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#120772 - m-ou-se:review, r=Nilstrieb

    Remove myself from review rotation.
    
    I've been unable to keep up with reviews. :(
    
    Not sure if this helps much, considering there aren't many other libs reviewers on the rotation at the moment.
    
    Hopefully I can add myself back again Soon™ when I can commit more time to reviewing.
    matthiaskrgr committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    abef17d View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#120775 - Nadrieril:more-min_exh_pats, r=com…

    …piler-errors
    
    Make `min_exhaustive_patterns` match `exhaustive_patterns` better
    
    Split off from rust-lang#120742.
    
    There remained two edge cases where `min_exhaustive_patterns` wasn't behaving like `exhaustive_patterns`. This fixes them, and tests the feature in a bunch more cases. I essentially went through all uses of `exhaustive_patterns` to see which ones would be interesting to compare between the two features.
    
    r? `@compiler-errors`
    matthiaskrgr committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    949e552 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#120778 - zetanumbers:refactor_try_instance_…

    …mir, r=compiler-errors
    
    Deduplicate `tcx.instance_mir(instance)` calls in `try_instance_mir`
    matthiaskrgr committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    3e523f6 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#120782 - oli-obk:track_errors8, r=WaffleLapkin

    Fix mir pass ICE in the presence of other errors
    
    fixes rust-lang#120779
    
    it is impossible to add a ui test for this, because it only reproduces in build-fail, but a test that also has errors in check-fail mode can't be made build-fail 🙃
    
    I would have to add a run-make test or sth, which is overkill for such a tiny thing imo.
    matthiaskrgr committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    1db56fb View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#120783 - integer32llc:improve-release-notes…

    …, r=Mark-Simulacrum
    
    Add release note for new ambiguous_wide_pointer_comparisons lint
    
    I found out about this new lint in Rust because I had code allowing the Clippy lint. Clippy alerted me to the lint name change, and I went searching for the new lint's name in the release notes and was surprised there wasn't an item for it.
    matthiaskrgr committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    9565e8d View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#120801 - oli-obk:drop_recursion_ice, r=Nils…

    …trieb
    
    Avoid ICE in drop recursion check in case of invalid drop impls
    
    fixes rust-lang#120787
    matthiaskrgr committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    ed52851 View commit details
    Browse the repository at this point in the history