Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #121887

Closed
wants to merge 24 commits into from
Closed

Commits on Mar 17, 2023

  1. Configuration menu
    Copy the full SHA
    53469cf View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Configuration menu
    Copy the full SHA
    0df002a View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Convert Unix{Datagram,Stream}::{set_}passcred() to per-OS traits

    These methods are the pre-stabilized API for obtaining peer credentials
    from an `AF_UNIX` socket, part of the `unix_socket_ancillary_data` feature.
    
    Their current behavior is to get/set one of the `SO_PASSCRED` (Linux),
    `LOCAL_CREDS_PERSISTENT` (FreeBSD), or `LOCAL_CREDS` (NetBSD) socket
    options. On other targets the `{set_}passcred()` methods do not exist.
    
    There are two problems with this approach:
    
    1. Having public methods only exist for certain targets isn't permitted
       in a stable `std` API.
    
    2. These options have generally similar purposes, but they are non-POSIX
       and their details can differ in subtle and surprising ways (such as
       whether they continue to be set after the next call to `recvmsg()`).
    
    Splitting into OS-specific extension traits is the preferred solution to
    both problems.
    jmillikin committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    2ed49fc View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Update E0716.md for clarity

    When reading through this, I got slightly hung up thinking the `let` it was referring to was the `let tmp` on line 25, which was confusing considering the comment states that the temporary is freed at the end of the block. I think adding this clarification could potentially help some beginners like myself without being overly verbose.
    carschandler committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    71a6973 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Configuration menu
    Copy the full SHA
    b353765 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Configuration menu
    Copy the full SHA
    c0ce0f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a1dbb61 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    d89c2c5 View commit details
    Browse the repository at this point in the history
  2. Move gather_comments.

    To the module where it is used, so it doesn't have to be `pub`.
    nnethercote committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    69f2c9c View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Move HandleStore into server.rs.

    This just moves the server-relevant parts of handles into `server.rs`.
    It introduces a new higher-order macro `with_api_handle_types` to avoid
    some duplication.
    
    This fixes two `FIXME` comments, and makes things clearer, by not having
    server code in `client.rs`.
    nnethercote committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    392159b View commit details
    Browse the repository at this point in the history
  2. remove hidden use of Global

    shamatar committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    fb8ac06 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bcccab8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    62baa67 View commit details
    Browse the repository at this point in the history
  5. Update E0716.md

    Clearer wording
    carschandler committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    50ff362 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Configuration menu
    Copy the full SHA
    7f97dfe View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#109263 - squell:master, r=cuviper

    fix typo in documentation for std::fs::Permissions
    
    Please check and re-check this PR carefully to see if I got this right.
    
    But by my logic, if the `read_only` function returns `true`, I would not expect be able to write to the file (it being read only); so this text is meant to clarify that `read_only` being `false` doesn't mean *you* can actually write to the file, just that "in general" someone is able to.
    Dylan-DPC committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    aeee1f5 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#117156 - jmillikin:os-unix-socket-ext, r=Am…

    …anieu,dtolnay
    
    Convert `Unix{Datagram,Stream}::{set_}passcred()` to per-OS traits
    
    These methods are the pre-stabilized API for obtaining peer credentials from an `AF_UNIX` socket, part of the `unix_socket_ancillary_data` feature.
    
    Their current behavior is to get/set one of the `SO_PASSCRED` (Linux), `LOCAL_CREDS_PERSISTENT` (FreeBSD), or `LOCAL_CREDS` (NetBSD) socket options. On other targets the `{set_}passcred()` methods do not exist.
    
    There are two problems with this approach:
    
    1. Having public methods only exist for certain targets isn't permitted in a stable `std` API.
    
    2. These options have generally similar purposes, but they are non-POSIX and their details can differ in subtle and surprising ways (such as whether they continue to be set after the next call to `recvmsg()`).
    
    Splitting into OS-specific extension traits is the preferred solution to both problems.
    Dylan-DPC committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    0fc922c View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#120684 - carschandler:patch-1, r=nnethercote

    Update E0716.md for clarity
    
    When reading through this, I got slightly hung up thinking the `let` it was referring to was the `let tmp` on line 25, which was confusing considering the comment states that the temporary is freed at the end of the block. I think adding this clarification could potentially help some beginners like myself without being overly verbose.
    Dylan-DPC committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    03a53eb View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#121739 - jieyouxu:loooong-typename, r=estebank

    Display short types for unimplemented trait
    
    Shortens unimplemented trait diagnostics. Now shows:
    
    ```
    error[E0277]: `Option<Option<Option<...>>>` doesn't implement `std::fmt::Display`
      --> $DIR/on_unimplemented_long_types.rs:4:17
       |
    LL |   pub fn foo() -> impl std::fmt::Display {
       |                   ^^^^^^^^^^^^^^^^^^^^^^ `Option<Option<Option<...>>>` cannot be formatted with the default formatter
    LL |
    LL | /     Some(Some(Some(Some(Some(Some(Some(Some(Some(S...
    LL | |         Some(Some(Some(Some(Some(Some(Some(Some(So...
    LL | |             Some(Some(Some(Some(Some(Some(Some(Som...
    LL | |                 Some(Some(Some(Some(Some(Some(Some...
    ...  |
    LL | |         ))))))))))),
    LL | |     )))))))))))
       | |_______________- return type was inferred to be `Option<Option<Option<...>>>` here
       |
       = help: the trait `std::fmt::Display` is not implemented for `Option<Option<Option<...>>>`
       = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead
    
    error: aborting due to 1 previous error
    
    For more information about this error, try `rustc --explain E0277`.
    ```
    
    I'm not 100% sure if this is desirable, or if we should just let the long types remain long. This is also kinda a short-term bandaid solution. The real long term solution is to properly migrate `rustc_trait_selection`'s error reporting to use translatable diagnostics and then properly handle type name printing.
    
    Fixes rust-lang#121687.
    Dylan-DPC committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    6f6cc27 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#121815 - nnethercote:mv-gather_comments, r=…

    …est31
    
    Move `gather_comments`.
    
    To the module where it is used, so it doesn't have to be `pub`.
    
    r? ``@est31``
    Dylan-DPC committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    0c46bc1 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#121835 - nnethercote:mv-HandleStore, r=bjorn3

    Move `HandleStore` into `server.rs`.
    
    This just moves the server-relevant parts of handles into `server.rs`. It introduces a new higher-order macro `with_api_handle_types` to avoid some duplication.
    
    This fixes two `FIXME` comments, and makes things clearer, by not having server code in `client.rs`.
    
    r? ``@bjorn3``
    Dylan-DPC committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    319228e View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#121847 - shamatar:btreemap_fix_implicits, r…

    …=cuviper
    
    Remove hidden use of Global
    
    Fixes rust-lang#121797
    Dylan-DPC committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    9c40705 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#121861 - tbu-:pr_floating_point_exact_examp…

    …les, r=workingjubilee
    
    Use the guaranteed precision of a couple of float functions in docs
    Dylan-DPC committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    8e8d5af View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#121875 - estebank:e0277-drive-by, r=compile…

    …r-errors
    
     Account for unmet T: !Copy in E0277 message
    
    ```
    error[E0277]: the trait bound `T: !Copy` is not satisfied
      --> $DIR/simple.rs:10:16
       |
    LL |     not_copy::<T>();
       |                ^ the trait bound `T: !Copy` is not satisfied
    ```
    instead of the current
    
    ```
    error[E0277]: the trait bound `T: !Copy` is not satisfied
      --> $DIR/simple.rs:10:16
       |
    LL |     not_copy::<T>();
       |                ^ the trait `!Copy` is not implemented for `T`
    ```
    Dylan-DPC committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    a404b52 View commit details
    Browse the repository at this point in the history