-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #121887
Rollup of 9 pull requests #121887
Commits on Mar 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 53469cf - Browse repository at this point
Copy the full SHA 53469cfView commit details
Commits on Aug 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0df002a - Browse repository at this point
Copy the full SHA 0df002aView commit details
Commits on Oct 25, 2023
-
Convert
Unix{Datagram,Stream}::{set_}passcred()
to per-OS traitsThese methods are the pre-stabilized API for obtaining peer credentials from an `AF_UNIX` socket, part of the `unix_socket_ancillary_data` feature. Their current behavior is to get/set one of the `SO_PASSCRED` (Linux), `LOCAL_CREDS_PERSISTENT` (FreeBSD), or `LOCAL_CREDS` (NetBSD) socket options. On other targets the `{set_}passcred()` methods do not exist. There are two problems with this approach: 1. Having public methods only exist for certain targets isn't permitted in a stable `std` API. 2. These options have generally similar purposes, but they are non-POSIX and their details can differ in subtle and surprising ways (such as whether they continue to be set after the next call to `recvmsg()`). Splitting into OS-specific extension traits is the preferred solution to both problems.
Configuration menu - View commit details
-
Copy full SHA for 2ed49fc - Browse repository at this point
Copy the full SHA 2ed49fcView commit details
Commits on Feb 5, 2024
-
When reading through this, I got slightly hung up thinking the `let` it was referring to was the `let tmp` on line 25, which was confusing considering the comment states that the temporary is freed at the end of the block. I think adding this clarification could potentially help some beginners like myself without being overly verbose.
Configuration menu - View commit details
-
Copy full SHA for 71a6973 - Browse repository at this point
Copy the full SHA 71a6973View commit details
Commits on Feb 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b353765 - Browse repository at this point
Copy the full SHA b353765View commit details
Commits on Feb 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c0ce0f3 - Browse repository at this point
Copy the full SHA c0ce0f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1dbb61 - Browse repository at this point
Copy the full SHA a1dbb61View commit details
Commits on Feb 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d89c2c5 - Browse repository at this point
Copy the full SHA d89c2c5View commit details -
To the module where it is used, so it doesn't have to be `pub`.
Configuration menu - View commit details
-
Copy full SHA for 69f2c9c - Browse repository at this point
Copy the full SHA 69f2c9cView commit details
Commits on Mar 1, 2024
-
Move
HandleStore
intoserver.rs
.This just moves the server-relevant parts of handles into `server.rs`. It introduces a new higher-order macro `with_api_handle_types` to avoid some duplication. This fixes two `FIXME` comments, and makes things clearer, by not having server code in `client.rs`.
Configuration menu - View commit details
-
Copy full SHA for 392159b - Browse repository at this point
Copy the full SHA 392159bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb8ac06 - Browse repository at this point
Copy the full SHA fb8ac06View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcccab8 - Browse repository at this point
Copy the full SHA bcccab8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62baa67 - Browse repository at this point
Copy the full SHA 62baa67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50ff362 - Browse repository at this point
Copy the full SHA 50ff362View commit details
Commits on Mar 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7f97dfe - Browse repository at this point
Copy the full SHA 7f97dfeView commit details -
Rollup merge of rust-lang#109263 - squell:master, r=cuviper
fix typo in documentation for std::fs::Permissions Please check and re-check this PR carefully to see if I got this right. But by my logic, if the `read_only` function returns `true`, I would not expect be able to write to the file (it being read only); so this text is meant to clarify that `read_only` being `false` doesn't mean *you* can actually write to the file, just that "in general" someone is able to.
Configuration menu - View commit details
-
Copy full SHA for aeee1f5 - Browse repository at this point
Copy the full SHA aeee1f5View commit details -
Rollup merge of rust-lang#117156 - jmillikin:os-unix-socket-ext, r=Am…
…anieu,dtolnay Convert `Unix{Datagram,Stream}::{set_}passcred()` to per-OS traits These methods are the pre-stabilized API for obtaining peer credentials from an `AF_UNIX` socket, part of the `unix_socket_ancillary_data` feature. Their current behavior is to get/set one of the `SO_PASSCRED` (Linux), `LOCAL_CREDS_PERSISTENT` (FreeBSD), or `LOCAL_CREDS` (NetBSD) socket options. On other targets the `{set_}passcred()` methods do not exist. There are two problems with this approach: 1. Having public methods only exist for certain targets isn't permitted in a stable `std` API. 2. These options have generally similar purposes, but they are non-POSIX and their details can differ in subtle and surprising ways (such as whether they continue to be set after the next call to `recvmsg()`). Splitting into OS-specific extension traits is the preferred solution to both problems.
Configuration menu - View commit details
-
Copy full SHA for 0fc922c - Browse repository at this point
Copy the full SHA 0fc922cView commit details -
Rollup merge of rust-lang#120684 - carschandler:patch-1, r=nnethercote
Update E0716.md for clarity When reading through this, I got slightly hung up thinking the `let` it was referring to was the `let tmp` on line 25, which was confusing considering the comment states that the temporary is freed at the end of the block. I think adding this clarification could potentially help some beginners like myself without being overly verbose.
Configuration menu - View commit details
-
Copy full SHA for 03a53eb - Browse repository at this point
Copy the full SHA 03a53ebView commit details -
Rollup merge of rust-lang#121739 - jieyouxu:loooong-typename, r=estebank
Display short types for unimplemented trait Shortens unimplemented trait diagnostics. Now shows: ``` error[E0277]: `Option<Option<Option<...>>>` doesn't implement `std::fmt::Display` --> $DIR/on_unimplemented_long_types.rs:4:17 | LL | pub fn foo() -> impl std::fmt::Display { | ^^^^^^^^^^^^^^^^^^^^^^ `Option<Option<Option<...>>>` cannot be formatted with the default formatter LL | LL | / Some(Some(Some(Some(Some(Some(Some(Some(Some(S... LL | | Some(Some(Some(Some(Some(Some(Some(Some(So... LL | | Some(Some(Some(Some(Some(Some(Some(Som... LL | | Some(Some(Some(Some(Some(Some(Some... ... | LL | | ))))))))))), LL | | ))))))))))) | |_______________- return type was inferred to be `Option<Option<Option<...>>>` here | = help: the trait `std::fmt::Display` is not implemented for `Option<Option<Option<...>>>` = note: in format strings you may be able to use `{:?}` (or {:#?} for pretty-print) instead error: aborting due to 1 previous error For more information about this error, try `rustc --explain E0277`. ``` I'm not 100% sure if this is desirable, or if we should just let the long types remain long. This is also kinda a short-term bandaid solution. The real long term solution is to properly migrate `rustc_trait_selection`'s error reporting to use translatable diagnostics and then properly handle type name printing. Fixes rust-lang#121687.
Configuration menu - View commit details
-
Copy full SHA for 6f6cc27 - Browse repository at this point
Copy the full SHA 6f6cc27View commit details -
Rollup merge of rust-lang#121815 - nnethercote:mv-gather_comments, r=…
…est31 Move `gather_comments`. To the module where it is used, so it doesn't have to be `pub`. r? ``@est31``
Configuration menu - View commit details
-
Copy full SHA for 0c46bc1 - Browse repository at this point
Copy the full SHA 0c46bc1View commit details -
Rollup merge of rust-lang#121835 - nnethercote:mv-HandleStore, r=bjorn3
Move `HandleStore` into `server.rs`. This just moves the server-relevant parts of handles into `server.rs`. It introduces a new higher-order macro `with_api_handle_types` to avoid some duplication. This fixes two `FIXME` comments, and makes things clearer, by not having server code in `client.rs`. r? ``@bjorn3``
Configuration menu - View commit details
-
Copy full SHA for 319228e - Browse repository at this point
Copy the full SHA 319228eView commit details -
Rollup merge of rust-lang#121847 - shamatar:btreemap_fix_implicits, r…
…=cuviper Remove hidden use of Global Fixes rust-lang#121797
Configuration menu - View commit details
-
Copy full SHA for 9c40705 - Browse repository at this point
Copy the full SHA 9c40705View commit details -
Rollup merge of rust-lang#121861 - tbu-:pr_floating_point_exact_examp…
…les, r=workingjubilee Use the guaranteed precision of a couple of float functions in docs
Configuration menu - View commit details
-
Copy full SHA for 8e8d5af - Browse repository at this point
Copy the full SHA 8e8d5afView commit details -
Rollup merge of rust-lang#121875 - estebank:e0277-drive-by, r=compile…
…r-errors Account for unmet T: !Copy in E0277 message ``` error[E0277]: the trait bound `T: !Copy` is not satisfied --> $DIR/simple.rs:10:16 | LL | not_copy::<T>(); | ^ the trait bound `T: !Copy` is not satisfied ``` instead of the current ``` error[E0277]: the trait bound `T: !Copy` is not satisfied --> $DIR/simple.rs:10:16 | LL | not_copy::<T>(); | ^ the trait `!Copy` is not implemented for `T` ```
Configuration menu - View commit details
-
Copy full SHA for a404b52 - Browse repository at this point
Copy the full SHA a404b52View commit details