Rollup of 10 pull requests #122139
Merged
Rollup of 10 pull requests #122139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`./x dist` currently crashes when cross compiling. Add the fix described by @catamorphism in rust-lang#110071. Fixes rust-lang#110071
…r-projections, r=lcnr
silence mismatched types errors for implied projections
Currently, if a trait bound is not satisfied, then we suppress any errors for the trait's supertraits not being satisfied, but still report errors for super projections not being satisfied.
For example:
```rust
trait Super {
type Assoc;
}
trait Sub: Super<Assoc = ()> {}
```
Before this PR, if `T: Sub` is not satisfied, then errors for `T: Super` are suppressed, but errors for `<T as Super>::Assoc == ()` are still shown. This PR makes it so that errors about super projections not being satisfied are also suppressed.
The errors are only suppressed if the span of the trait obligation matches the span of the super predicate obligation to avoid silencing error that are not related. This PR removes some differences between the spans of supertraits and super projections to make the suppression work correctly.
This PR fixes the majority of the diagnostics fallout when making `Thin` a supertrait of `Sized` (in a future PR).
cc rust-lang#120354 (comment)
cc `@lcnr`
Apply `EarlyBinder` only to `TraitRef` in `ImplTraitHeader` Resolves rust-lang#121852 This PR 1. Moves `EarlyBinder` to `TraitRef` inside `ImplTraitHeader`, 2. Changes visibility of `coherence::builtin::check_trait` to `pub(super)` from `pub` as it seems not being re-exported from the `coherence` module.
Add proper cfgs for struct HirIdValidator used only with debug-assert See rust-lang#122065 (comment). I think it's due to rust-lang#121752.
Rust is a proper name: rust → Rust I only went over the library where it might be user-visible -- I noticed this in the `time` docs.
Make `x t miri` respect `MIRI_TEMP` (I don't want to override `TMPDIR`, as that might affect other things) r? ``@RalfJung``
…affleLapkin Make not finding core a fatal error Similar to rust-lang#120472, this prevents terminal spam. In particular, it makes the good diagnostic visible when you try to use a target that's not installed.
…ler-errors Cancel parsing ever made during recovery Fixes rust-lang#122112 It would be nice if diagnostics from recovery were automatically cancelled... 🤔
…-bounds, r=oli-obk Don't require specifying unrelated assoc types when trait alias is in `dyn` type Object types must specify the associated types for all of the principal trait ref's supertraits. However, we weren't doing elaboration properly, so we incorrectly errored with erroneous suggestions to specify associated types that were unrelated to that principal trait ref. To fix this, use proper supertrait elaboration when expanding trait aliases in `conv_object_ty_poly_trait_ref`. **NOTE**: Please use the ignore-whitespace option when reviewing. This only touches a handful of lines. r? oli-obk or please feel free to reassign. Fixes rust-lang#122118
…ld-belongs-to-unix, r=ChrisDenton Fix `tidy --bless` on ̶X̶e̶n̶i̶x̶ Windows As reported in rust-lang#120628 (comment) the requested `tidy --bless` implementation didn't take into account the fact that earlier the linting code canonicalized things to use the OS path separator. This makes it so that the path separator is always rewritten back as '/', which should fix the variance there. r? ``@ChrisDenton``
…ur-ozkan Set `RustcDocs` to only run on host `./x dist` currently crashes when cross compiling. Add the fix described by `@catamorphism` in rust-lang#110071. Fixes rust-lang#110071
rustbot
added
A-testsuite
rustbot
added
T-bootstrap
|
@bors r+ p=5 rollup=never |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 52f8aec14c In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 7, 2024
|
Finished benchmarking commit (1c580bc): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 647.761s -> 647.822s (0.01%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
EarlyBinderonly toTraitRefinImplTraitHeader#122043 (ApplyEarlyBinderonly toTraitRefinImplTraitHeader)x t mirirespectMIRI_TEMP#122110 (Makex t mirirespectMIRI_TEMP)dyntype #122123 (Don't require specifying unrelated assoc types when trait alias is indyntype)tidy --blesson ̶X̶e̶n̶i̶x̶ Windows #122126 (Fixtidy --blesson ̶X̶e̶n̶i̶x̶ Windows)RustcDocsto only run on host #122129 (SetRustcDocsto only run on host)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup