Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] backports #122524

Merged
merged 6 commits into from
Mar 15, 2024
Merged

[beta] backports #122524

merged 6 commits into from
Mar 15, 2024

Commits on Mar 15, 2024

  1. AST validation: Improve handling of inherent impls nested within func… 

    …tions and anon consts

(cherry picked from commit 7d428db)
    @fmease @cuviper
    fmease authored and cuviper committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    92512b1 View commit details
    Browse the repository at this point in the history

  2. downgrade mutable-ptr-in-final-value from hard-error to future-incomp… 

    …at lint to address issue 121610.

(cherry picked from commit a8549b4)
    @pnkfelix @cuviper
    pnkfelix authored and cuviper committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    25d3cbb View commit details
    Browse the repository at this point in the history

  3. regression test from 121610. 

    (cherry picked from commit f86b46a)
    @pnkfelix @cuviper
    pnkfelix authored and cuviper committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    6c06ca0 View commit details
    Browse the repository at this point in the history

  4. Added deny(const_eval_mutable_ptr_in_final_value) attribute to all … 

    …tests that were expecting the hard error for it.

I attempted to do this in a manner that preserved the line numbers to reduce the
review effort on the resulting diff, but we still have to deal with the
ramifications of how a future-incompat lint behaves compared to a hard-error (in
terms of its impact on the diagnostic output).

(cherry picked from commit 1c3424b)
    @pnkfelix @cuviper
    pnkfelix authored and cuviper committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    9cf28f2 View commit details
    Browse the repository at this point in the history

  5. Added an "Explanation" header and expanded that section for the newly… 

    … added lint.

(cherry picked from commit 6ca46da)
    @pnkfelix @cuviper
    pnkfelix authored and cuviper committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2ade18a View commit details
    Browse the repository at this point in the history

  6. Add produces as tidy requires 

    (cherry picked from commit ae374cf)
    @wesleywiser @cuviper
    wesleywiser authored and cuviper committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    6b0992f View commit details
    Browse the repository at this point in the history