Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the more informative generic type inference failure error on method calls on raw pointers #122768

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Use the more informative generic type inference failure error on method calls on raw pointers #122768

merged 2 commits into from
Apr 9, 2024

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Mar 20, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2024

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 20, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2024

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

WaffleLapkin
WaffleLapkin approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with green CI

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member

You're not supposed to remove long error explanation files. Take a look at E0001.md to see how to update it.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 20, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2024

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

GuillaumeGomez
GuillaumeGomez reviewed Mar 20, 2024
View reviewed changes
compiler/rustc_error_codes/src/error_codes/E0699.md
@@ -1,3 +1,5 @@
#### Note: this error code is no longer emitted by the compiler.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to remove E0699 from the failing code example attributes just below.

GuillaumeGomez
GuillaumeGomez reviewed Mar 20, 2024
View reviewed changes
compiler/rustc_error_codes/src/lib.rs
@@ -441,7 +441,7 @@ E0695: 0695,
E0696: 0696,
E0697: 0697,
E0698: 0698,
E0699: 0699,
E0699: 0699, // REMOVED: merged into generic inference var error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can comment it and move it to the commented list below (but keep your comment).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no I cannot 😆 I tried this first.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait really? O.o

Dark magic going on...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment at the top of the file says to not remove things anymore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum... E0744 is commented, its file still exists and you can get it from rustc --explain E0744, so I'm surprised. Oh well, as long as CI passes...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor Author

oli-obk commented Apr 8, 2024

@bors r=WaffleLapkin

@bors
Copy link
Contributor

bors commented Apr 8, 2024

📌 Commit 7f9a4af has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2024
@bors
Auto merge of rust-lang#123663 - matthiaskrgr:rollup-1qnj9j3, r=matth…
86b603c 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#122768 (Use the more informative generic type inference failure error on method calls on raw pointers)
 - rust-lang#123620 (sanitizers: Create the rustc_sanitizers crate)
 - rust-lang#123624 ([rustdoc] [GUI tests] Make theme switching closer to reality)
 - rust-lang#123636 (Update books)
 - rust-lang#123647 (rustdoc: slightly clean up the synthesis of blanket impls)
 - rust-lang#123648 (Avoid ICEing without the pattern_types feature gate)
 - rust-lang#123649 (KCFI: Use legal charset in shim encoding)
 - rust-lang#123652 (Fix UI tests with dist-vendored dependencies)
 - rust-lang#123655 (Remove unimplemented!() from BinOp::ty() function)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 643dee7 into rust-lang:master Apr 9, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2024
@rust-timer
Unrolled build for rust-lang#122768
3c395de 
Rollup merge of rust-lang#122768 - oli-obk:why_is_E0699_so_bad, r=WaffleLapkin

Use the more informative generic type inference failure error on method calls on raw pointers
@veera-sivarajan veera-sivarajan mentioned this pull request May 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
7 participants
@oli-obk @rustbot @rust-log-analyzer @GuillaumeGomez @bors @WaffleLapkin @michaelwoerister